Attention is currently required from: Michał Żygowski, Michał Kopeć. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63656 )
Change subject: mb/msi/ms7d25: Configure PCIe Root Ports ......................................................................
Patch Set 10: Verified-1
(57 comments)
File src/mainboard/msi/ms7d25/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/664695d1_d4aceab7 PS10, Line 142: _PAD_CFG_STRUCT(VGPIO_4, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/20b5c6b1_2e23834b PS10, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/407cf94f_ea51ac4f PS10, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_0 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/18d170ee_05dc4d24 PS10, Line 173: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/b4faf8b6_ca229968 PS10, Line 173: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_1 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/8dacb674_f122e2cd PS10, Line 174: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/32d6525e_d433dca7 PS10, Line 174: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_2 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/edd0bbc2_c5b6e6d5 PS10, Line 175: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/51ec9625_c5a101c3 PS10, Line 175: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_3 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/a55fd757_c57e8e43 PS10, Line 176: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_8 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/8ee13660_61df5a15 PS10, Line 176: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_8 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/ae6cdd89_2065ad52 PS10, Line 177: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_9 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/a83a123f_c76e2bf5 PS10, Line 177: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_9 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/27b8ded2_dd39dd9c PS10, Line 178: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_10 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/ec04e404_e6e378c4 PS10, Line 178: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_10 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/340d5892_e7b1d080 PS10, Line 179: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_11 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/8e56a57b_4d2d68ff PS10, Line 179: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_11 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/f5f7ff4c_13c1f008 PS10, Line 425: // _PAD_CFG_STRUCT(VGPIO_PCIE_0, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/46d4236a_e23ef1c9 PS10, Line 426: // _PAD_CFG_STRUCT(VGPIO_PCIE_1, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/e4c29aa7_c7285b1f PS10, Line 427: // _PAD_CFG_STRUCT(VGPIO_PCIE_2, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/02eef888_e128edd1 PS10, Line 428: // _PAD_CFG_STRUCT(VGPIO_PCIE_3, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/66a3025b_cd50103c PS10, Line 429: // _PAD_CFG_STRUCT(VGPIO_PCIE_4, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/7dba2c71_709a9018 PS10, Line 430: // _PAD_CFG_STRUCT(VGPIO_PCIE_5, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/2c93575a_7ef64a19 PS10, Line 431: // _PAD_CFG_STRUCT(VGPIO_PCIE_6, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/d501c995_d8aa4455 PS10, Line 432: // _PAD_CFG_STRUCT(VGPIO_PCIE_7, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/45b5e746_e0b36604 PS10, Line 433: // _PAD_CFG_STRUCT(VGPIO_PCIE_8, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/36058a72_617cbc68 PS10, Line 434: // _PAD_CFG_STRUCT(VGPIO_PCIE_9, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/a68fd95b_f8b6f7da PS10, Line 435: // _PAD_CFG_STRUCT(VGPIO_PCIE_10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/b6e06024_8cce82e9 PS10, Line 436: // _PAD_CFG_STRUCT(VGPIO_PCIE_11, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/7802452f_4d5979f3 PS10, Line 437: // _PAD_CFG_STRUCT(VGPIO_PCIE_12, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/bf6cddfb_b50fe729 PS10, Line 438: // _PAD_CFG_STRUCT(VGPIO_PCIE_13, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/e2691e55_07453d4b PS10, Line 439: // _PAD_CFG_STRUCT(VGPIO_PCIE_14, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/97c01c30_1bae8314 PS10, Line 440: // _PAD_CFG_STRUCT(VGPIO_PCIE_15, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/345d584a_5dd9fdff PS10, Line 441: // _PAD_CFG_STRUCT(VGPIO_PCIE_64, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/a94d0e16_6895086c PS10, Line 442: // _PAD_CFG_STRUCT(VGPIO_PCIE_65, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/5308bb01_b88cc9f0 PS10, Line 443: // _PAD_CFG_STRUCT(VGPIO_PCIE_66, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/1d61a638_9049668b PS10, Line 444: // _PAD_CFG_STRUCT(VGPIO_PCIE_67, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/137b2a70_dbaf1830 PS10, Line 447: // _PAD_CFG_STRUCT(VGPIO_PCIE_16, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/cd244411_e912e03d PS10, Line 448: // _PAD_CFG_STRUCT(VGPIO_PCIE_17, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/66529fdb_d68c223b PS10, Line 449: // _PAD_CFG_STRUCT(VGPIO_PCIE_18, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/6e57c2e4_6a1568ec PS10, Line 450: // _PAD_CFG_STRUCT(VGPIO_PCIE_19, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/99257d90_1a1d5e75 PS10, Line 451: // _PAD_CFG_STRUCT(VGPIO_PCIE_20, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/b2bda3c0_d720056b PS10, Line 452: // _PAD_CFG_STRUCT(VGPIO_PCIE_21, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/4e6750ef_e32d8ef3 PS10, Line 453: // _PAD_CFG_STRUCT(VGPIO_PCIE_22, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/53f3597e_4f7d0ace PS10, Line 454: // _PAD_CFG_STRUCT(VGPIO_PCIE_23, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/7c50e8db_5b282e52 PS10, Line 455: // _PAD_CFG_STRUCT(VGPIO_PCIE_24, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/90d5d969_b509d800 PS10, Line 456: // _PAD_CFG_STRUCT(VGPIO_PCIE_25, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/ff8ce6f3_2687894d PS10, Line 457: // _PAD_CFG_STRUCT(VGPIO_PCIE_26, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/f2f50c98_785f8a21 PS10, Line 458: // _PAD_CFG_STRUCT(VGPIO_PCIE_27, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/c03cf746_e37cacae PS10, Line 459: // _PAD_CFG_STRUCT(VGPIO_PCIE_28, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/cdc08aab_b013e701 PS10, Line 460: // _PAD_CFG_STRUCT(VGPIO_PCIE_29, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/40cd47ce_f0a4c411 PS10, Line 461: // _PAD_CFG_STRUCT(VGPIO_PCIE_30, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/78a0e55e_dd297681 PS10, Line 462: // _PAD_CFG_STRUCT(VGPIO_PCIE_31, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/41599a4b_0478d8cf PS10, Line 463: // _PAD_CFG_STRUCT(VGPIO_PCIE_68, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/36eea5d9_003c3b1c PS10, Line 464: // _PAD_CFG_STRUCT(VGPIO_PCIE_69, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/2c8e796d_7b6f4f9a PS10, Line 465: // _PAD_CFG_STRUCT(VGPIO_PCIE_70, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150250): https://review.coreboot.org/c/coreboot/+/63656/comment/784178ed_83d4dcef PS10, Line 466: // _PAD_CFG_STRUCT(VGPIO_PCIE_71, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters