Attention is currently required from: Nico Huber, Subrata Banik, Dinesh Gehlot, Angel Pons, Julius Werner, Maximilian Brune, Lean Sheng Tan, Werner Zeh, ron minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74797 )
Change subject: cpu/x86/reset16.S: Remove handcoded reset vector
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Well the question is how stale the comment is, as it was written ~20y ago? Truncating the relative address to 3 bytes should also have worked, so I don't really understand the comment even... How often does the tooling break 16bit relocations? Well we use other 16bit relocations for both loading GDT and doing 16bit far jumps in the tree without implementing them in bytes, without any apparent issues for years.
Also you can let the tooling handle the 16bit relocations properly, rather than implement asserts in the linker scripts.
What is improved?
"_bogus3 = ASSERT(_start16bit >= 0xffff0000, "_start16bit too low. Please report.");" in the linker script can likely be dropped, although I haven't tested that yet. If the jump is close, it can use an 8bit relative jump making code even more compact ^^.
I moved the reset to a different file in the follow-up which makes it easier to read.
I mostly just played around to see if the statement in the comment was still valid since I needed to implement something similar in different codebase.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie371000c60d66c032a8dcccb98e7627df09d3aa4
Gerrit-Change-Number: 74797
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 03 May 2023 08:54:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-MessageType: comment