HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32547
Change subject: mb/google: Remove unused 'include <smbios.h>' ......................................................................
mb/google: Remove unused 'include <smbios.h>'
Change-Id: Ib96c317391745fa5afea785e3c7441124b3fc252 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/beltino/mainboard.c M src/mainboard/google/link/i915.c M src/mainboard/google/stout/mainboard.c 3 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32547/1
diff --git a/src/mainboard/google/beltino/mainboard.c b/src/mainboard/google/beltino/mainboard.c index e0fd105..7bda2f6 100644 --- a/src/mainboard/google/beltino/mainboard.c +++ b/src/mainboard/google/beltino/mainboard.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <smbios.h> #include <types.h> #include <arch/acpi.h> #include <arch/io.h> @@ -25,8 +24,8 @@ #include <device/pci_ops.h> #include <southbridge/intel/lynxpoint/pch.h> #include <vendorcode/google/chromeos/chromeos.h> -#include "onboard.h"
+#include "onboard.h"
void mainboard_suspend_resume(void) { diff --git a/src/mainboard/google/link/i915.c b/src/mainboard/google/link/i915.c index e09785d..2799540 100644 --- a/src/mainboard/google/link/i915.c +++ b/src/mainboard/google/link/i915.c @@ -29,7 +29,6 @@ #include "ec.h" #include <southbridge/intel/bd82x6x/pch.h> #include <northbridge/intel/sandybridge/gma.h> -#include <smbios.h> #include <device/pci.h> #include <ec/google/chromeec/ec.h>
diff --git a/src/mainboard/google/stout/mainboard.c b/src/mainboard/google/stout/mainboard.c index 5f51a6b..3afca00 100644 --- a/src/mainboard/google/stout/mainboard.c +++ b/src/mainboard/google/stout/mainboard.c @@ -25,7 +25,6 @@ #include "onboard.h" #include "ec.h" #include <southbridge/intel/bd82x6x/pch.h> -#include <smbios.h> #include <device/pci.h> #include <ec/quanta/it8518/ec.h> #include <vendorcode/google/chromeos/chromeos.h>
Hello Lijian Zhao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32547
to look at the new patch set (#2).
Change subject: mb/google: Remove unused 'include <smbios.h>' ......................................................................
mb/google: Remove unused 'include <smbios.h>'
Change-Id: Ib96c317391745fa5afea785e3c7441124b3fc252 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/beltino/mainboard.c M src/mainboard/google/link/i915.c M src/mainboard/google/stout/mainboard.c 3 files changed, 7 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32547/2
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32547 )
Change subject: mb/google: Remove unused 'include <smbios.h>' ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32547 )
Change subject: mb/google: Remove unused 'include <smbios.h>' ......................................................................
mb/google: Remove unused 'include <smbios.h>'
Change-Id: Ib96c317391745fa5afea785e3c7441124b3fc252 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32547 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lijian Zhao lijian.zhao@intel.com --- M src/mainboard/google/beltino/mainboard.c M src/mainboard/google/link/i915.c M src/mainboard/google/stout/mainboard.c 3 files changed, 7 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved
diff --git a/src/mainboard/google/beltino/mainboard.c b/src/mainboard/google/beltino/mainboard.c index e0fd105..7bda2f6 100644 --- a/src/mainboard/google/beltino/mainboard.c +++ b/src/mainboard/google/beltino/mainboard.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <smbios.h> #include <types.h> #include <arch/acpi.h> #include <arch/io.h> @@ -25,8 +24,8 @@ #include <device/pci_ops.h> #include <southbridge/intel/lynxpoint/pch.h> #include <vendorcode/google/chromeos/chromeos.h> -#include "onboard.h"
+#include "onboard.h"
void mainboard_suspend_resume(void) { diff --git a/src/mainboard/google/link/i915.c b/src/mainboard/google/link/i915.c index e09785d..12d424c 100644 --- a/src/mainboard/google/link/i915.c +++ b/src/mainboard/google/link/i915.c @@ -25,19 +25,18 @@ #include <arch/io.h> #include <arch/interrupt.h> #include <boot/coreboot_tables.h> -#include "onboard.h" -#include "ec.h" #include <southbridge/intel/bd82x6x/pch.h> #include <northbridge/intel/sandybridge/gma.h> -#include <smbios.h> #include <device/pci.h> #include <ec/google/chromeec/ec.h> - #include <cpu/x86/tsc.h> #include <cpu/x86/cache.h> #include <cpu/x86/mtrr.h> #include <cpu/x86/msr.h> #include <edid.h> + +#include "ec.h" +#include "onboard.h" #include "i915io.h"
enum { diff --git a/src/mainboard/google/stout/mainboard.c b/src/mainboard/google/stout/mainboard.c index 5f51a6b..05de8cb 100644 --- a/src/mainboard/google/stout/mainboard.c +++ b/src/mainboard/google/stout/mainboard.c @@ -22,14 +22,14 @@ #include <arch/acpi.h> #include <arch/interrupt.h> #include <boot/coreboot_tables.h> -#include "onboard.h" -#include "ec.h" #include <southbridge/intel/bd82x6x/pch.h> -#include <smbios.h> #include <device/pci.h> #include <ec/quanta/it8518/ec.h> #include <vendorcode/google/chromeos/chromeos.h>
+#include "ec.h" +#include "onboard.h" + void mainboard_suspend_resume(void) { /* Stout EC needs to be put back in ACPI mode */
-
HAOUAS Elyes (Code Review) -
Lijian Zhao (Code Review)
-
Patrick Georgi (Code Review)