Patrick Georgi merged this change.

View Change

Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved
mb/google: Remove unused 'include <smbios.h>'

Change-Id: Ib96c317391745fa5afea785e3c7441124b3fc252
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32547
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
---
M src/mainboard/google/beltino/mainboard.c
M src/mainboard/google/link/i915.c
M src/mainboard/google/stout/mainboard.c
3 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/src/mainboard/google/beltino/mainboard.c b/src/mainboard/google/beltino/mainboard.c
index e0fd105..7bda2f6 100644
--- a/src/mainboard/google/beltino/mainboard.c
+++ b/src/mainboard/google/beltino/mainboard.c
@@ -14,7 +14,6 @@
* GNU General Public License for more details.
*/

-#include <smbios.h>
#include <types.h>
#include <arch/acpi.h>
#include <arch/io.h>
@@ -25,8 +24,8 @@
#include <device/pci_ops.h>
#include <southbridge/intel/lynxpoint/pch.h>
#include <vendorcode/google/chromeos/chromeos.h>
-#include "onboard.h"

+#include "onboard.h"

void mainboard_suspend_resume(void)
{
diff --git a/src/mainboard/google/link/i915.c b/src/mainboard/google/link/i915.c
index e09785d..12d424c 100644
--- a/src/mainboard/google/link/i915.c
+++ b/src/mainboard/google/link/i915.c
@@ -25,19 +25,18 @@
#include <arch/io.h>
#include <arch/interrupt.h>
#include <boot/coreboot_tables.h>
-#include "onboard.h"
-#include "ec.h"
#include <southbridge/intel/bd82x6x/pch.h>
#include <northbridge/intel/sandybridge/gma.h>
-#include <smbios.h>
#include <device/pci.h>
#include <ec/google/chromeec/ec.h>
-
#include <cpu/x86/tsc.h>
#include <cpu/x86/cache.h>
#include <cpu/x86/mtrr.h>
#include <cpu/x86/msr.h>
#include <edid.h>
+
+#include "ec.h"
+#include "onboard.h"
#include "i915io.h"

enum {
diff --git a/src/mainboard/google/stout/mainboard.c b/src/mainboard/google/stout/mainboard.c
index 5f51a6b..05de8cb 100644
--- a/src/mainboard/google/stout/mainboard.c
+++ b/src/mainboard/google/stout/mainboard.c
@@ -22,14 +22,14 @@
#include <arch/acpi.h>
#include <arch/interrupt.h>
#include <boot/coreboot_tables.h>
-#include "onboard.h"
-#include "ec.h"
#include <southbridge/intel/bd82x6x/pch.h>
-#include <smbios.h>
#include <device/pci.h>
#include <ec/quanta/it8518/ec.h>
#include <vendorcode/google/chromeos/chromeos.h>

+#include "ec.h"
+#include "onboard.h"
+
void mainboard_suspend_resume(void)
{
/* Stout EC needs to be put back in ACPI mode */

To view, visit change 32547. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96c317391745fa5afea785e3c7441124b3fc252
Gerrit-Change-Number: 32547
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged