David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )
Change subject: mainboard/portwell/m107: Do initial mainboard commit ......................................................................
Patch Set 11:
(26 comments)
marking some comments as resolved...
https://review.coreboot.org/#/c/29470/8/src/mainboard/portwell/m107/devicetr... File src/mainboard/portwell/m107/devicetree.cb:
https://review.coreboot.org/#/c/29470/8/src/mainboard/portwell/m107/devicetr... PS8, Line 99: device pci 0b.0 on end # 8086 22DC - PUNIT/DPTF
PUNIT device is by code. Should be disabled here also.
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... File src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex:
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 35: # bit7 : 0 = CRC covers bytes 0 ~ 128
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 61: # bits[7:6]: 0 = reserved
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 80: # bits[7:5]: reserved
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 90: 01
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 117: 78
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 151: 3C
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 154: 3C
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 181: 41
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 187: 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 190: 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 193: 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 203: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 204: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 209: 80 CE
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 212: 01
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 215: 12 1B
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 218: 00 00 00 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 225: 20 20
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 234: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 240: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 241: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 242: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/1/src/mainboard/portwell/m107/spd/SAMS... PS1, Line 243: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/spd/SAMS... File src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex:
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/spd/SAMS... PS2, Line 187: 00
trailing whitespace
Done
https://review.coreboot.org/#/c/29470/2/src/mainboard/portwell/m107/spd/SAMS... PS2, Line 218: 00 00 00 00
trailing whitespace
Done
-
David Hendricks (Code Review)