Attention is currently required from: Arthur Heymans, Felix Singer, Nico Huber, Subrata Banik.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80775?usp=email )
Change subject: Revert "lib: Explicitly declare heap as NOLOAD"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Sure, sure. That's why I said it also depends on the difficulty and that it's not a must ;) […]
Yeah, like Nico said, I think it's usually better to revert first so that we don't need to make design decisions about a forward fix under time pressure. The forward fix has not been up for the 24h period and the rules for ignoring that period say it should be "as limited in scope as possible", which I think applies better to this revert.
Let me just put this in now before we discuss it to death so the tree doesn't remain broken. We can still go with Arthur's patch afterwards if we want (it should be easy to rebase), let's just take the time to discuss the different options there first.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80775?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d49e2dc49cd2935a9d8023c989869ec9558039e
Gerrit-Change-Number: 80775
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 29 Feb 2024 00:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment