Attention is currently required from: Lance Zhao, Martin Roth, Philipp Hug, Tim Wawrzynczak, Christian Walter, Angel Pons, Julius Werner, Ron Minnich.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58080 )
Change subject: src/acpi to src/lib: Fix spelling errors
......................................................................
Patch Set 3:
(1 comment)
File src/device/oprom/x86emu/prim_ops.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129769):
https://review.coreboot.org/c/coreboot/+/58080/comment/2e8dd06a_71e78e55
PS3, Line 2461: * will only support up to feature 1, which we set in register EAX.
code indent should use tabs where possible
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58080
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b8ecdfe75d99028fee820a2034466a8ad1c5e63
Gerrit-Change-Number: 58080
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Philipp Hug
philipp.hug@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 04 Oct 2021 18:47:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment