Attention is currently required from: Christian Walter, Julius Werner.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74856 )
Change subject: security/tpm: Add Kconfig to allow payload control of TPM1
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
How is this practically different from just not enabling CONFIG_TPM1 at all (and letting the payload […]
if CONFIG_TPM1 isn't selected, then you're selecting CONFIG_NO_TPM. I haven't tested it, but without TPM1, I'm pretty sure there's a bunch of ACPI left out of the SSDT, particularly related to PP. But I will re-test and see if that works sufficiently well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74856
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb7db109cbcc1a0166d95b6130b624b635bb7ac9
Gerrit-Change-Number: 74856
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Sat, 29 Apr 2023 02:54:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment