Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41370 )
Change subject: aspeed/ast2050: Fix when resources are added ......................................................................
aspeed/ast2050: Fix when resources are added
This change moves adding of resources to read_resources() instead of set_resources().
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I7d5e4aa0fc28dd35f774957ef303d8854aa07913 --- M src/drivers/aspeed/ast2050/ast2050.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/41370/1
diff --git a/src/drivers/aspeed/ast2050/ast2050.c b/src/drivers/aspeed/ast2050/ast2050.c index 5a1d92d..5cb7198 100644 --- a/src/drivers/aspeed/ast2050/ast2050.c +++ b/src/drivers/aspeed/ast2050/ast2050.c @@ -11,13 +11,13 @@ #include "../common/aspeed_coreboot.h" #include "../common/ast_drv.h"
-static void aspeed_ast2050_set_resources(struct device *dev) +static void aspeed_ast2050_read_resources(struct device *dev) { /* Reserve VGA regions */ mmio_resource(dev, 3, 0xa0000 >> 10, 0x1ffff >> 10);
- /* Run standard resource set routine */ - pci_dev_set_resources(dev); + /* Run standard resource read routine */ + pci_dev_read_resources(dev); }
static void aspeed_ast2050_init(struct device *dev) @@ -52,8 +52,8 @@ }
static struct device_operations aspeed_ast2050_ops = { - .read_resources = pci_dev_read_resources, - .set_resources = aspeed_ast2050_set_resources, + .read_resources = aspeed_ast2050_read_resources, + .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = aspeed_ast2050_init, };
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41370 )
Change subject: aspeed/ast2050: Fix when resources are added ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41370 )
Change subject: aspeed/ast2050: Fix when resources are added ......................................................................
Patch Set 3: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41370 )
Change subject: aspeed/ast2050: Fix when resources are added ......................................................................
Patch Set 3:
Patrick, Michael, could you please boot-test this? Thanks.
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41370 )
Change subject: aspeed/ast2050: Fix when resources are added ......................................................................
aspeed/ast2050: Fix when resources are added
This change moves adding of resources to read_resources() instead of set_resources().
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I7d5e4aa0fc28dd35f774957ef303d8854aa07913 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41370 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/aspeed/ast2050/ast2050.c 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Aaron Durbin: Looks good to me, approved
diff --git a/src/drivers/aspeed/ast2050/ast2050.c b/src/drivers/aspeed/ast2050/ast2050.c index 5a1d92d..5cb7198 100644 --- a/src/drivers/aspeed/ast2050/ast2050.c +++ b/src/drivers/aspeed/ast2050/ast2050.c @@ -11,13 +11,13 @@ #include "../common/aspeed_coreboot.h" #include "../common/ast_drv.h"
-static void aspeed_ast2050_set_resources(struct device *dev) +static void aspeed_ast2050_read_resources(struct device *dev) { /* Reserve VGA regions */ mmio_resource(dev, 3, 0xa0000 >> 10, 0x1ffff >> 10);
- /* Run standard resource set routine */ - pci_dev_set_resources(dev); + /* Run standard resource read routine */ + pci_dev_read_resources(dev); }
static void aspeed_ast2050_init(struct device *dev) @@ -52,8 +52,8 @@ }
static struct device_operations aspeed_ast2050_ops = { - .read_resources = pci_dev_read_resources, - .set_resources = aspeed_ast2050_set_resources, + .read_resources = aspeed_ast2050_read_resources, + .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = aspeed_ast2050_init, };
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41370 )
Change subject: aspeed/ast2050: Fix when resources are added ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 2/2/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : FAIL : https://lava.9esec.io/r/3431 "QEMU x86 q35/ich9" using payload SeaBIOS : FAIL : https://lava.9esec.io/r/3430 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3429 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3428
Please note: This test is under development and might not be accurate at all!
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41370 )
Change subject: aspeed/ast2050: Fix when resources are added ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 2/2/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : FAIL : https://lava.9esec.io/r/3443 "QEMU x86 q35/ich9" using payload SeaBIOS : FAIL : https://lava.9esec.io/r/3442 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3441 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3440
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aaron Durbin (Code Review)
-
Angel Pons (Code Review)
-
Furquan Shaikh (Code Review)
-
Paul Menzel (Code Review)