Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30926
Change subject: soc/samsung/exynos5420: Disable BOOTBLOCK_CONSOLE ......................................................................
soc/samsung/exynos5420: Disable BOOTBLOCK_CONSOLE
Add a new Kconfig NO_BOOTBLOCK_CONSOLE to disable the BOOTBLOCK_CONSOLE option completely. The commit message of fbb11cf (ARM: Separate the early console (romstage) from the bootblock console.) states that it doesn't work before romstage on Exynos 5420.
Change-Id: I9b56a52f2555b5233300f27031a9ef50e7ab7cea Signed-off-by: Nico Huber nico.h@gmx.de --- M src/console/Kconfig M src/soc/samsung/exynos5420/Kconfig 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/30926/1
diff --git a/src/console/Kconfig b/src/console/Kconfig index 82f7441..61ba667 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -1,8 +1,11 @@ menu "Console"
+config NO_BOOTBLOCK_CONSOLE + bool + config BOOTBLOCK_CONSOLE bool "Enable early (bootblock) console output." - depends on C_ENVIRONMENT_BOOTBLOCK + depends on C_ENVIRONMENT_BOOTBLOCK && !NO_BOOTBLOCK_CONSOLE default y help Use console during the bootblock if supported diff --git a/src/soc/samsung/exynos5420/Kconfig b/src/soc/samsung/exynos5420/Kconfig index 7fb2f8f..7b87650 100644 --- a/src/soc/samsung/exynos5420/Kconfig +++ b/src/soc/samsung/exynos5420/Kconfig @@ -7,6 +7,7 @@ select GENERIC_UDELAY select HAVE_UART_SPECIAL select RELOCATABLE_MODULES + select NO_BOOTBLOCK_CONSOLE bool default n
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30926 )
Change subject: soc/samsung/exynos5420: Disable BOOTBLOCK_CONSOLE ......................................................................
Patch Set 1:
Thanks for the push :) I needed it to look a little deeper.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30926 )
Change subject: soc/samsung/exynos5420: Disable BOOTBLOCK_CONSOLE ......................................................................
Patch Set 1: Code-Review+2
Thanks, this should work (although I'm still not sure if we need the user-configurable option at all).
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30926 )
Change subject: soc/samsung/exynos5420: Disable BOOTBLOCK_CONSOLE ......................................................................
soc/samsung/exynos5420: Disable BOOTBLOCK_CONSOLE
Add a new Kconfig NO_BOOTBLOCK_CONSOLE to disable the BOOTBLOCK_CONSOLE option completely. The commit message of fbb11cf (ARM: Separate the early console (romstage) from the bootblock console.) states that it doesn't work before romstage on Exynos 5420.
Change-Id: I9b56a52f2555b5233300f27031a9ef50e7ab7cea Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/30926 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/console/Kconfig M src/soc/samsung/exynos5420/Kconfig 2 files changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/console/Kconfig b/src/console/Kconfig index 82f7441..61ba667 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -1,8 +1,11 @@ menu "Console"
+config NO_BOOTBLOCK_CONSOLE + bool + config BOOTBLOCK_CONSOLE bool "Enable early (bootblock) console output." - depends on C_ENVIRONMENT_BOOTBLOCK + depends on C_ENVIRONMENT_BOOTBLOCK && !NO_BOOTBLOCK_CONSOLE default y help Use console during the bootblock if supported diff --git a/src/soc/samsung/exynos5420/Kconfig b/src/soc/samsung/exynos5420/Kconfig index 7fb2f8f..7b87650 100644 --- a/src/soc/samsung/exynos5420/Kconfig +++ b/src/soc/samsung/exynos5420/Kconfig @@ -7,6 +7,7 @@ select GENERIC_UDELAY select HAVE_UART_SPECIAL select RELOCATABLE_MODULES + select NO_BOOTBLOCK_CONSOLE bool default n
-
Julius Werner (Code Review) -
Nico Huber (Code Review)