Attention is currently required from: Kapil Porwal, Nick Vaccaro, Reka Norman, Scott Chao.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79244?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa: update GPP_F17 to edge trigger ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79244/comment/b8130720_62e57519 : PS1, Line 7: update GPP_F17 to edge trigger Maybe:
Make GPP_F17 edge triggered to avoid spamming EC
https://review.coreboot.org/c/coreboot/+/79244/comment/953d932a_a2367c95 : PS1, Line 9: it will cause and it causes AP to keep sending
https://review.coreboot.org/c/coreboot/+/79244/comment/98fc092b_11b1abc2 : PS1, Line 9: AP Application Processor?
https://review.coreboot.org/c/coreboot/+/79244/comment/ff57c7f7_531d4645 : PS1, Line 9: GPP_F17 Unfortunately, I do not understand the commit message without looking at the comment in the diff. Maybe elaborate, what GPP_F17 does?
https://review.coreboot.org/c/coreboot/+/79244/comment/a9d54081_7103f356 : PS1, Line 10: connect connecting
https://review.coreboot.org/c/coreboot/+/79244/comment/e82221e6_ba83feae : PS1, Line 14: TEST=Test on joxer with 6 units, 0 out of 60 times. 1. What does “unit” refer to? 2. How often did it happen before?