Change in coreboot[master]: mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Nick Chen (Code Review)

22 Sep 2020 22 Sep '20

12:42 p.m.

Nick Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45598 )

Change subject: mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram ......................................................................

mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram

In order to pass DB type-C USB2 eye diagram, DB USB2 PHY register needs to be overridde.

port#1 PortUsb20Enable=1 Usb2PhyPetxiset=7 Usb2PhyTxiset=7 Usb2PhyPredeemp=3 Usb2PhyPehalfbit=0

BUG=b:169105751 Signed-off-by: nick_xr_chen nick_xr_chen@wistron.corp-partner.google.com Change-Id: If076c644783fa2992ac062d6469f9c49e6d5ff24 --- M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/45598/1

diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb index b04b1e7..46dfc5e 100644 --- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb +++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb @@ -48,6 +48,15 @@ }, }, }" + #usb2 Eye Diagram + register "usb2_ports[4]" = "{ + .enable = 1, + .tx_bias = 7, + .tx_emp_enable = 7, + .pre_emp_bias - 3, + .pre_emp_bit = 0, + }" + device domain 0 on device pci 04.0 off end device pci 15.0 on

Attachments:

attachment.htm (text/html — 3.2 KB)

Show replies by date

Nick Chen (Code Review)

22 Sep 22 Sep

1:11 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45598

to look at the new patch set (#2).

Change subject: mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram ......................................................................

mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram

In order to pass DB type-C USB2 eye diagram, DB USB2 PHY register needs to be overridde.

port#1 PortUsb20Enable=1 Usb2PhyPetxiset=7 Usb2PhyTxiset=7 Usb2PhyPredeemp=3 Usb2PhyPehalfbit=0

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/45598/2

Nick Chen (Code Review)

1:50 p.m.

Hello build bot (Jenkins), Patrick Georgi, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45598

to look at the new patch set (#3).

Change subject: mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram ......................................................................

mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram

In order to pass DB type-C USB2 eye diagram, DB USB2 PHY register needs to be overridde.

port#1 PortUsb20Enable=1 Usb2PhyPetxiset=7 Usb2PhyTxiset=7 Usb2PhyPredeemp=3 Usb2PhyPehalfbit=0

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/45598/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/45598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If076c644783fa2992ac062d6469f9c49e6d5ff24 Gerrit-Change-Number: 45598 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Nick Chen (Code Review)

1:57 p.m.

Hello build bot (Jenkins), Patrick Georgi, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45598

to look at the new patch set (#4).

Change subject: mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram ......................................................................

mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram

In order to pass DB type-C USB2 eye diagram, DB USB2 PHY register needs to be overridde.

port#1 PortUsb20Enable=1 Usb2PhyPetxiset=7 Usb2PhyTxiset=7 Usb2PhyPredeemp=3 Usb2PhyPehalfbit=0

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/45598/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/45598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If076c644783fa2992ac062d6469f9c49e6d5ff24 Gerrit-Change-Number: 45598 Gerrit-PatchSet: 4 Gerrit-Owner: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

23 Sep 23 Sep

4:41 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45598 )

Change subject: mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram ......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG@7 PS4, Line 7: mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram

https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG@9 PS4, Line 9: needs : to be overridde. needs to be overridden

https://review.coreboot.org/c/coreboot/+/45598/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45598/4/src/mainboard/google/voltee... PS4, Line 51: usb2 suggestion: These settings improve the USB2 Port1 eye diagram

-- To view, visit https://review.coreboot.org/c/coreboot/+/45598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If076c644783fa2992ac062d6469f9c49e6d5ff24 Gerrit-Change-Number: 45598 Gerrit-PatchSet: 4 Gerrit-Owner: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Tue, 22 Sep 2020 19:41:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nick Chen (Code Review)

10:24 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/eldrid: mb/google/volteer: Improve Eldrid ...

Hello build bot (Jenkins), Patrick Georgi, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45598

to look at the new patch set (#5).

Change subject: mb/google/volteer/variants/eldrid: mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram ......................................................................

mb/google/volteer/variants/eldrid: mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram

In order to pass DB type-C USB2 eye diagram, DB USB2 PHY register needs to be overridden.

port#1 PortUsb20Enable=1 Usb2PhyPetxiset=7 Usb2PhyTxiset=7 Usb2PhyPredeemp=3 Usb2PhyPehalfbit=0

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/45598/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/45598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If076c644783fa2992ac062d6469f9c49e6d5ff24 Gerrit-Change-Number: 45598 Gerrit-PatchSet: 5 Gerrit-Owner: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Nick Chen (Code Review)

10:26 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram

Hello build bot (Jenkins), Patrick Georgi, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45598

to look at the new patch set (#6).

Change subject: mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram ......................................................................

mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram

In order to pass DB type-C USB2 eye diagram, DB USB2 PHY register needs to be overridden.

port#1 PortUsb20Enable=1 Usb2PhyPetxiset=7 Usb2PhyTxiset=7 Usb2PhyPredeemp=3 Usb2PhyPehalfbit=0

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/45598/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/45598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If076c644783fa2992ac062d6469f9c49e6d5ff24 Gerrit-Change-Number: 45598 Gerrit-PatchSet: 6 Gerrit-Owner: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Nick Chen (Code Review)

10:27 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram

Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45598 )

Change subject: mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram ......................................................................

Patch Set 6:

(3 comments)

https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG@7 PS4, Line 7: mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram

...

mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram

Done

https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG@9 PS4, Line 9: needs : to be overridde.

...

needs to be overridden

Done

https://review.coreboot.org/c/coreboot/+/45598/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45598/4/src/mainboard/google/voltee... PS4, Line 51: usb2

...

suggestion: These settings improve the USB2 Port1 eye diagram

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If076c644783fa2992ac062d6469f9c49e6d5ff24 Gerrit-Change-Number: 45598 Gerrit-PatchSet: 6 Gerrit-Owner: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Wed, 23 Sep 2020 01:27:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

24 Sep 24 Sep

1:26 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45598 )

Change subject: mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If076c644783fa2992ac062d6469f9c49e6d5ff24 Gerrit-Change-Number: 45598 Gerrit-PatchSet: 6 Gerrit-Owner: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Wed, 23 Sep 2020 16:26:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

28 Sep 28 Sep

6:31 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45598 )

Change subject: mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram ......................................................................

mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram

In order to pass DB type-C USB2 eye diagram, DB USB2 PHY register needs to be overridden.

port#1 PortUsb20Enable=1 Usb2PhyPetxiset=7 Usb2PhyTxiset=7 Usb2PhyPredeemp=3 Usb2PhyPehalfbit=0

BUG=b:169105751 Signed-off-by: nick_xr_chen nick_xr_chen@wistron.corp-partner.google.com Change-Id: If076c644783fa2992ac062d6469f9c49e6d5ff24 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45598 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb index b04b1e7..6e9d743 100644 --- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb +++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb @@ -48,6 +48,15 @@ }, }, }" + #These settings improve the USB2 Port1 eye diagram + register "usb2_ports[4]" = "{ + .enable = 1, + .tx_bias = 7, + .tx_emp_enable = 7, + .pre_emp_bias = 3, + .pre_emp_bit = 0, + }" + device domain 0 on device pci 04.0 off end device pci 15.0 on

-- To view, visit https://review.coreboot.org/c/coreboot/+/45598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If076c644783fa2992ac062d6469f9c49e6d5ff24 Gerrit-Change-Number: 45598 Gerrit-PatchSet: 7 Gerrit-Owner: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: merged

1471

days inactive

1477

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Nick Chen (Code Review)
Patrick Georgi (Code Review)
Tim Wawrzynczak (Code Review)