Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48118 )
Change subject: mb/intel/ehlcrb: Remove ChromeOS EC support EHL smihandler ......................................................................
mb/intel/ehlcrb: Remove ChromeOS EC support EHL smihandler
Since there is no ChromeOS support for EHL, removing ChromeOS EC codes from smihandler.c.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: Id474c3b04a82c03dda6514cc4565b58fb790b9c1 --- M src/mainboard/intel/elkhartlake_crb/Makefile.inc D src/mainboard/intel/elkhartlake_crb/smihandler.c 2 files changed, 0 insertions(+), 38 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/48118/1
diff --git a/src/mainboard/intel/elkhartlake_crb/Makefile.inc b/src/mainboard/intel/elkhartlake_crb/Makefile.inc index cf9e1c9..69a9368 100644 --- a/src/mainboard/intel/elkhartlake_crb/Makefile.inc +++ b/src/mainboard/intel/elkhartlake_crb/Makefile.inc @@ -10,7 +10,6 @@ ramstage-y += mainboard.c ramstage-y += board_id.c
-smm-y += smihandler.c
subdirs-y += variants/baseboard CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include diff --git a/src/mainboard/intel/elkhartlake_crb/smihandler.c b/src/mainboard/intel/elkhartlake_crb/smihandler.c deleted file mode 100644 index be0066a..0000000 --- a/src/mainboard/intel/elkhartlake_crb/smihandler.c +++ /dev/null @@ -1,37 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <baseboard/variants.h> -#include <cpu/x86/smm.h> -#include <ec/google/chromeec/ec.h> -#include <ec/google/chromeec/smm.h> -#include <elog.h> -#include <intelblocks/smihandler.h> -#include <baseboard/ec.h> - -void mainboard_smi_espi_handler(void) -{ - if (CONFIG(EC_GOOGLE_CHROMEEC)) - chromeec_smi_process_events(); -} - -void mainboard_smi_sleep(u8 slp_typ) -{ - if (CONFIG(EC_GOOGLE_CHROMEEC)) - chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, - MAINBOARD_EC_S5_WAKE_EVENTS); -} - -int mainboard_smi_apmc(u8 apmc) -{ - if (CONFIG(EC_GOOGLE_CHROMEEC)) - chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS, MAINBOARD_EC_SMI_EVENTS); - - return 0; -} - -void elog_gsmi_cb_mainboard_log_wake_source(void) -{ - if (CONFIG(EC_GOOGLE_CHROMEEC)) - google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | - MAINBOARD_EC_S3_WAKE_EVENTS); -}
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48118 )
Change subject: mb/intel/ehlcrb: Remove ChromeOS EC support EHL smihandler ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@7 PS1, Line 7: Remove ChromeOS EC support EHL smihandler Remove ChromeOS EC support from smihandler
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@9 PS1, Line 9: EHL EHL CRB
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@10 PS1, Line 10: codes support
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@11 PS1, Line 11: In fact you are completely dropping smihandler.c instead of removing parts of it. Why not just say something like "Since there is no ChromeOS support for EHL CRB, drop smihandler.c which just deals with ChromeOS support."?
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Aamir Bohra, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48118
to look at the new patch set (#2).
Change subject: mb/intel/ehlcrb: Remove ChromeOS EC support from smihandler ......................................................................
mb/intel/ehlcrb: Remove ChromeOS EC support from smihandler
Since there is no ChromeOS support for EHL CRB, drop smihandler.c which just deals with ChromeOS support.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: Id474c3b04a82c03dda6514cc4565b58fb790b9c1 --- M src/mainboard/intel/elkhartlake_crb/Makefile.inc D src/mainboard/intel/elkhartlake_crb/smihandler.c 2 files changed, 0 insertions(+), 38 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/48118/2
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48118 )
Change subject: mb/intel/ehlcrb: Remove ChromeOS EC support from smihandler ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@7 PS1, Line 7: Remove ChromeOS EC support EHL smihandler
Remove ChromeOS EC support from smihandler
Done
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@9 PS1, Line 9: EHL
EHL CRB
Done
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@10 PS1, Line 10: codes
support
Done
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@11 PS1, Line 11:
In fact you are completely dropping smihandler.c instead of removing parts of it. […]
Done
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48118 )
Change subject: mb/intel/ehlcrb: Remove ChromeOS EC support from smihandler ......................................................................
Patch Set 2: Code-Review+2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48118 )
Change subject: mb/intel/ehlcrb: Remove ChromeOS EC support from smihandler ......................................................................
Patch Set 2: Code-Review+2
Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48118 )
Change subject: mb/intel/ehlcrb: Remove ChromeOS EC support from smihandler ......................................................................
mb/intel/ehlcrb: Remove ChromeOS EC support from smihandler
Since there is no ChromeOS support for EHL CRB, drop smihandler.c which just deals with ChromeOS support.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: Id474c3b04a82c03dda6514cc4565b58fb790b9c1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48118 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/intel/elkhartlake_crb/Makefile.inc D src/mainboard/intel/elkhartlake_crb/smihandler.c 2 files changed, 0 insertions(+), 38 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/intel/elkhartlake_crb/Makefile.inc b/src/mainboard/intel/elkhartlake_crb/Makefile.inc index cf9e1c9..69a9368 100644 --- a/src/mainboard/intel/elkhartlake_crb/Makefile.inc +++ b/src/mainboard/intel/elkhartlake_crb/Makefile.inc @@ -10,7 +10,6 @@ ramstage-y += mainboard.c ramstage-y += board_id.c
-smm-y += smihandler.c
subdirs-y += variants/baseboard CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include diff --git a/src/mainboard/intel/elkhartlake_crb/smihandler.c b/src/mainboard/intel/elkhartlake_crb/smihandler.c deleted file mode 100644 index be0066a..0000000 --- a/src/mainboard/intel/elkhartlake_crb/smihandler.c +++ /dev/null @@ -1,37 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <baseboard/variants.h> -#include <cpu/x86/smm.h> -#include <ec/google/chromeec/ec.h> -#include <ec/google/chromeec/smm.h> -#include <elog.h> -#include <intelblocks/smihandler.h> -#include <baseboard/ec.h> - -void mainboard_smi_espi_handler(void) -{ - if (CONFIG(EC_GOOGLE_CHROMEEC)) - chromeec_smi_process_events(); -} - -void mainboard_smi_sleep(u8 slp_typ) -{ - if (CONFIG(EC_GOOGLE_CHROMEEC)) - chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, - MAINBOARD_EC_S5_WAKE_EVENTS); -} - -int mainboard_smi_apmc(u8 apmc) -{ - if (CONFIG(EC_GOOGLE_CHROMEEC)) - chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS, MAINBOARD_EC_SMI_EVENTS); - - return 0; -} - -void elog_gsmi_cb_mainboard_log_wake_source(void) -{ - if (CONFIG(EC_GOOGLE_CHROMEEC)) - google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | - MAINBOARD_EC_S3_WAKE_EVENTS); -}
-
Frans Hendriks (Code Review) -
Lean Sheng Tan (Code Review)
-
Werner Zeh (Code Review)