Attention is currently required from: Chen, Gang C, David Hendricks, Jincheng Li, Shuo Liu, TangYiwei.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81320?usp=email )
Change subject: mainboard: Introduce BIOS_SIZE ......................................................................
Patch Set 1: Code-Review-2
(1 comment)
File src/mainboard/Kconfig:
https://review.coreboot.org/c/coreboot/+/81320/comment/a5b08d6b_7fc77143 : PS1, Line 257: config BIOS_SIZE_KB_16384 : bool "16384 KB (16 MB)" : help : Choose this option if your BIOS region is 16384 KB (16 MB). : : config BIOS_SIZE_KB_32768 : bool "32768 KB (32 MB)" : help : Choose this option if your BIOS region is 32768 KB (32 MB). : : config BIOS_SIZE_KB_49512 : bool "49512 KB (48 MB)" : help : Choose this option if your BIOS region is 49512 KB (48 MB). : : # Map the config names to the value : config BIOS_SIZE : hex : default 0x01000000 if BIOS_SIZE_KB_16384 : default 0x02000000 if BIOS_SIZE_KB_32768 : default 0x03000000 if BIOS_SIZE_KB_49512 : default 0x01000000 Drop the Kconfig variables. The FMAP should have all the information needed about the size of the BIOS region. Besides this is intel specific stuff in the generic mainboard dir...