Attention is currently required from: Felix Held, Julius Werner, Lean Sheng Tan, Matt DeVillier, Maximilian Brune, Philipp Hug, ron minnich.
Benjamin Doron has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/84796?usp=email )
Change subject: lib/{fit,fit_payload}.c: Enhance support for FIT images
......................................................................
Patch Set 11:
(2 comments)
File src/lib/fit.c:
https://review.coreboot.org/c/coreboot/+/84796/comment/2315064d_27226fd6?usp... :
PS11, Line 512: strcmp(config->name, default_config_name)
This can crash if `default_config_name` remains `NULL` because there is no `default` prop. […]
I thought I pushed that, it's in my local copy. It might've gotten lost in my git stashes. Anyways, thanks for catching this, I'll double check that I haven't lost anything else there.
File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/84796/comment/51494d29_c7b687d1?usp... :
PS9, Line 22: printk(BIOS_CRIT, "WEAK: Generic code called to load a FIT kernel!\n");
String doesn't seem to be changed in latest patch set yet?
Right, like in the other comment, I think I answered some of these before pushing my work on new year's.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84796?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6a21954c0dc5fd820d135e8cd0599ce87903a1c0
Gerrit-Change-Number: 84796
Gerrit-PatchSet: 11
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 16 Jan 2025 20:23:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org