Prudhvi Yarlagadda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29957 )
Change subject: libpayload: Add UART for qcs405 ......................................................................
Patch Set 23:
(9 comments)
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/configs/config.... File payloads/libpayload/configs/config.mistral:
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/configs/config.... PS20, Line 6: CONFIG_LP_USB=y : CONFIG_LP_USB_EHCI=y : CONFIG_LP_USB_XHCI=y
We will remove this in our next patch. […]
Done
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/... File payloads/libpayload/drivers/serial/qcs405.c:
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/... PS20, Line 286: .uart_dm_base = UART2_DM_BASE,
We will add this uart_fill_lb() functionality in our next patch.
Done
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/... PS20, Line 287: .blsp_uart = BLSP1_UART2,
We will remove this in our next patch.
Done
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/... PS20, Line 291: #define read32(addr) readl(addr)
We will remove this in our next patch.
Done
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/... PS20, Line 329: * @wait: indicates blocking call or not blocking call
We will remove this part of the code in our next patch.
Done
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/... PS20, Line 347: readl
We will change this in our next patch.
Done
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/... PS20, Line 373: if (*data == 0)
Agree, We will remove this in our next patch.
Done
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/... PS20, Line 544: /* For simplicity sake let's rely on coreboot initalizing the UART. */
We will remove this initialization part in our next patch.
We are seeing issues if we remove the initialization (line #552). Please let us know if we can release new patch set with other comments addressed. Meanwhile we work to fix the issue with uart init.
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/... PS20, Line 556: consout.putchar = serial_putchar;
We will do this assignment in the struct initializer for consin/consout in our next patch.
Done
-
Prudhvi Yarlagadda (Code Review)