Attention is currently required from: Martin Roth. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52115 )
Change subject: mb/google/guybrush: PCIe GPIOs - enable enables, disable resets ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52115/comment/04b4b8ca_d117d19e PS1, Line 54: HIGH Don't you need the *_RST{_L} signals to be deasserted before FSP-M runs?
https://review.coreboot.org/c/coreboot/+/52115/comment/a7a452a6_b2866612 PS1, Line 169: /* EN_PP3300_WLAN */ Is there any timing requirement between EN_PP3300_WLAN and WLAN_DISABLE signals? Same for WWAN?