Change in coreboot[master]: Makefile: Add unit-tests help and targets list - coreboot-gerrit

14 Apr 2021


      Attention is currently required from: Martin Roth, Jakub Czapiga.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52293 )
Change subject: Makefile: Add unit-tests help and targets list
......................................................................
Patch Set 1:
(1 comment)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/52293/comment/c50c2346_b32d96a5 
PS1, Line 186: 		echo "  $$t";             \
Can't this just be done in make (e.g. $(subst " ","\n",$(sort $(alltests)) or something like that)? That tr piping looks pretty horrible.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52293
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I464a76cbea1f4afbc3fc772960787952e61b95b9
Gerrit-Change-Number: 52293
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Comment-Date: Tue, 13 Apr 2021 22:16:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment