Attention is currently required from: Dtrain Hsu, Frank Wu, Ian Feng, John Su, Nick Vaccaro, Subrata Banik, Van Chen.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79183?usp=email )
Change subject: mb/google/nissa/var/craaskov: Add 6W and 15W DPTF parameters
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/google/brya/variants/craaskov/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79183/comment/ce11514b_42e4fbc7 :
PS2, Line 1: fw_config
please use tab.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79183?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I02b4187000eec9990bf10a57875b23007f7bdd12
Gerrit-Change-Number: 79183
Gerrit-PatchSet: 2
Gerrit-Owner: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-Attention: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 20 Nov 2023 06:02:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment