Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85920?usp=email )
(
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/fatcat: Select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat ......................................................................
mb/google/fatcat: Select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat
This patch selects the ISH main firmware Kconfig to prevent google/fatcat from trying to retrieve a dummy ISH SHIM firmware version, since ISH FW in google/fatcat will be part of the kernel firmware image.
BUG=b:370984186 TEST=Build and boot google/fatcat, config exists in coreboot.config
Change-Id: Id24394cb6c6dbaed13c87612da341e47eb69895f Signed-off-by: Jayvik Desai jayvik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85920 Reviewed-by: Subrata Banik subratabanik@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/fatcat/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/fatcat/Kconfig b/src/mainboard/google/fatcat/Kconfig index ec85a38..f408c0b 100644 --- a/src/mainboard/google/fatcat/Kconfig +++ b/src/mainboard/google/fatcat/Kconfig @@ -44,6 +44,7 @@ select BOARD_GOOGLE_FATCAT_COMMON select CHROMEOS_WIFI_SAR if CHROMEOS select DRIVERS_INTEL_ISH + select DRIVER_INTEL_ISH_HAS_MAIN_FW select DRIVERS_INTEL_USB4_RETIMER select HAVE_SLP_S0_GATE select MAINBOARD_HAS_CHROMEOS