Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Kane Chen, Karthik Ramasubramanian.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52874 )
Change subject: soc/intel/{adl,tgl,jsl}: Enable power button smi after BS_CHIPS_EXIT
......................................................................
Patch Set 7:
(3 comments)
File src/soc/intel/alderlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/52874/comment/a2d8d862_784f5eff
PS6, Line 147: /*
: * Enable Power button SMI only after BS_DEV_INIT_CHIPS (FSP-S) is done.
: */
nit: can be a one-line comment
Done
File src/soc/intel/jasperlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/52874/comment/9bcbd8d7_0a28bed1
PS6, Line 98: /*
: * Enable Power button SMI only after BS_DEV_INIT_CHIPS (FSP-S) is done.
: */
same
Done
File src/soc/intel/tigerlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/52874/comment/339004df_2464376c
PS6, Line 151: /*
: * Enable Power button SMI only after BS_DEV_INIT_CHIPS (FSP-S) is done.
: */
same
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52874
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70b871f2676a89bc782116e02beba5c20ec51eef
Gerrit-Change-Number: 52874
Gerrit-PatchSet: 7
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 05 May 2021 23:59:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment