Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25213 )
Change subject: sdm845: Add USB support on cheza platform
......................................................................
Patch Set 66:
(2 comments)
LGTM but comment style still needs to be fixed. (T.mike, maybe you could just do that?)
https://review.coreboot.org/#/c/25213/66/src/soc/qualcomm/sdm845/usb.c
File src/soc/qualcomm/sdm845/usb.c:
https://review.coreboot.org/#/c/25213/66/src/soc/qualcomm/sdm845/usb.c@646
PS66, Line 646: printk(BIOS_INFO, "Starting DWC3 and PHY resets for USB\n");
nit: should move this into reset_usb0()/reset_usb1() to be able to print the right controller name
https://review.coreboot.org/#/c/25213/66/src/soc/qualcomm/sdm845/usb.c@788
PS66, Line 788: /* DEBUG_STAT5: wait for 160uS for PLL lock;
Correct multi-line comment style is either
/*
* Like
* this
*/
or
/* Like
this */
(note no star on continuation line for short version).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I475a7757239acb8ef22a4d61afd59b304a7f0acc
Gerrit-Change-Number: 25213
Gerrit-PatchSet: 66
Gerrit-Owner: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: Ciluveru chandana kishori
cchiluve@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Chandana Kishori Chiluveru
cchiluve@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 26 Mar 2019 23:17:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment