Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35921 )
Change subject: mb/google/glados: port to FSP 2.0
......................................................................
Uploaded patch set 5.
(1 comment)
https://review.coreboot.org/c/coreboot/+/35921/4/src/mainboard/google/glados...
File src/mainboard/google/glados/romstage.c:
https://review.coreboot.org/c/coreboot/+/35921/4/src/mainboard/google/glados...
PS4, Line 33: #ifdef EC_ENABLE_KEYBOARD_BACKLIGHT
: /* Turn on keyboard backlight to indicate we are booting */
: const FSPM_ARCH_UPD *arch_upd = &mupd->FspmArchUpd;
: if (arch_upd->BootMode != FSP_BOOT_ON_S3_RESUME)
: google_chromeec_kbbacklight(25);
: #endif
remove one tab from entire block - #ifdefs are not indented to match current code level
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35921
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0
Gerrit-Change-Number: 35921
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Oct 2019 17:45:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment