EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40656 )
Change subject: mb/google/deltaur: Enable DRIVERS_I2C_HID for Touchpad ......................................................................
mb/google/deltaur: Enable DRIVERS_I2C_HID for Touchpad
Cirque touchpad uses I2C_HID driver.
BUG=b:152931802 TEST=Touch pad can work well in the OS.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I3f8d5abad2f153f395ba7e3f979ad3d2526e040c --- M src/mainboard/google/deltaur/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/40656/1
diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index 74c8201..7395c00 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -2,6 +2,7 @@ def_bool n select BOARD_ROMSIZE_KB_32768 select DRIVERS_I2C_GENERIC + select DRIVERS_I2C_HID select DRIVERS_INTEL_ISH select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40656 )
Change subject: mb/google/deltaur: Enable DRIVERS_I2C_HID for Touchpad ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40656 )
Change subject: mb/google/deltaur: Enable DRIVERS_I2C_HID for Touchpad ......................................................................
mb/google/deltaur: Enable DRIVERS_I2C_HID for Touchpad
Cirque touchpad uses I2C_HID driver.
BUG=b:152931802 TEST=Touch pad can work well in the OS.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I3f8d5abad2f153f395ba7e3f979ad3d2526e040c Reviewed-on: https://review.coreboot.org/c/coreboot/+/40656 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/deltaur/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index 74c8201..7395c00 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -2,6 +2,7 @@ def_bool n select BOARD_ROMSIZE_KB_32768 select DRIVERS_I2C_GENERIC + select DRIVERS_I2C_HID select DRIVERS_INTEL_ISH select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40656 )
Change subject: mb/google/deltaur: Enable DRIVERS_I2C_HID for Touchpad ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2728 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2727 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2726 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2725
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
EricR Lai (Code Review)
-
Tim Wawrzynczak (Code Review)