Change in coreboot[master]: soc/amd: rename common Kconfig and use wildcard for SoC-specific Kconfig
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47701 )
Change subject: soc/amd: rename common Kconfig and use wildcard for SoC-specific Kconfig ......................................................................
soc/amd: rename common Kconfig and use wildcard for SoC-specific Kconfig
By renaming the AMD SOC common Kconfig file the wildcard to source all AMD SoC-specific Kconfig files won't match to it and it can be sourced after all SoC-specific Kconfig files in the sub-directories are sourced.
Change-Id: Iaaa5aad23eb6364d46b279101f3969db9f182607 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/Kconfig R src/soc/amd/common/Kconfig.common 2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/47701/1
diff --git a/src/soc/amd/Kconfig b/src/soc/amd/Kconfig index 7c08f03..77eac6b 100644 --- a/src/soc/amd/Kconfig +++ b/src/soc/amd/Kconfig @@ -1,6 +1,5 @@ # Load all chipsets before common -source "src/soc/amd/picasso/Kconfig" -source "src/soc/amd/stoneyridge/Kconfig" +source "src/soc/amd/*/Kconfig"
# Load common defaults last -source "src/soc/amd/common/Kconfig" +source "src/soc/amd/common/Kconfig.common" diff --git a/src/soc/amd/common/Kconfig b/src/soc/amd/common/Kconfig.common similarity index 100% rename from src/soc/amd/common/Kconfig rename to src/soc/amd/common/Kconfig.common
Felix Held has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/47701 )
Change subject: soc/amd: rename common Kconfig and use wildcard for SoC-specific Kconfig ......................................................................
soc/amd: rename common Kconfig and use wildcard for SoC-specific Kconfig
By renaming the AMD SOC common Kconfig file the wildcard to source all AMD SoC-specific Kconfig files won't match to it and it can be sourced after all SoC-specific Kconfig files in the sub-directories are sourced. This change allows adding new SoCs without having to edit the soc/amd Kconfig file.
Change-Id: Iaaa5aad23eb6364d46b279101f3969db9f182607 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/Kconfig R src/soc/amd/common/Kconfig.common 2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/47701/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47701 )
Change subject: soc/amd: rename common Kconfig and use wildcard for SoC-specific Kconfig ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47701 )
Change subject: soc/amd: rename common Kconfig and use wildcard for SoC-specific Kconfig ......................................................................
soc/amd: rename common Kconfig and use wildcard for SoC-specific Kconfig
By renaming the AMD SOC common Kconfig file the wildcard to source all AMD SoC-specific Kconfig files won't match to it and it can be sourced after all SoC-specific Kconfig files in the sub-directories are sourced. This change allows adding new SoCs without having to edit the soc/amd Kconfig file.
Change-Id: Iaaa5aad23eb6364d46b279101f3969db9f182607 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47701 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/soc/amd/Kconfig R src/soc/amd/common/Kconfig.common 2 files changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/soc/amd/Kconfig b/src/soc/amd/Kconfig index 7c08f03..77eac6b 100644 --- a/src/soc/amd/Kconfig +++ b/src/soc/amd/Kconfig @@ -1,6 +1,5 @@ # Load all chipsets before common -source "src/soc/amd/picasso/Kconfig" -source "src/soc/amd/stoneyridge/Kconfig" +source "src/soc/amd/*/Kconfig"
# Load common defaults last -source "src/soc/amd/common/Kconfig" +source "src/soc/amd/common/Kconfig.common" diff --git a/src/soc/amd/common/Kconfig b/src/soc/amd/common/Kconfig.common similarity index 100% rename from src/soc/amd/common/Kconfig rename to src/soc/amd/common/Kconfig.common
-
Felix Held (Code Review) -
Nico Huber (Code Review)