Attention is currently required from: Furquan Shaikh, Martin Roth, Kangheui Won, Paul Menzel, Rob Barnes, EricR Lai.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49236 )
Change subject: mb/google/zork/var/vilboz: Fix FW_CONFIG_SHIFT_WWAN value
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49236/comment/c773b86a_8205e9f6
PS2, Line 9: Fix FW_CONFIG_SHIFT_WWAN value.
Okay I understand it now but still it'd be better to write it in commit message for future reference […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica6d04f9c48aa0800189283608bf57416ac75cf7
Gerrit-Change-Number: 49236
Gerrit-PatchSet: 3
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 11 Jan 2021 03:05:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Su
john_su@compal.corp-partner.google.com
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Gerrit-MessageType: comment