Attention is currently required from: Subrata Banik, Vinay Kumar, Tim Wawrzynczak, Sridhar Siricilla.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62630 )
Change subject: mb/google/brya: Disable c1-state auto demotion for Brya & Brask
......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62630/comment/2d0996c4_336d66e4
PS5, Line 9: C state
Done […]
Done
https://review.coreboot.org/c/coreboot/+/62630/comment/4f51a94f_e3d1c5cc
PS5, Line 13: disabling this feature results in 110 mW power savings
Yes, no performance impact was seen with disabling autodemotion. […]
Yes Subrata, as per my understanding it would not have impact in case of Balanced power/performance policy. Since coreboot uses balanced policy, it's working in our case.
@Vinay, Can you help to clarify if my understanding is incorrect?
Commit Message:
https://review.coreboot.org/c/coreboot/+/62630/comment/272dfc0d_649db983
PS6, Line 7: C
c1
Done
https://review.coreboot.org/c/coreboot/+/62630/comment/a6df7419_e494af32
PS6, Line 9: c-state
c1 state
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41eea916cdfe4a86e4d263e3191f5cb40fa33a90
Gerrit-Change-Number: 62630
Gerrit-PatchSet: 7
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: Vinay Kumar
vinay.kumar@intel.com
Gerrit-CC: Vinay Kumar
vinay.kumar@intel.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Mon, 07 Mar 2022 17:16:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Vinay Kumar
vinay.kumar@intel.corp-partner.google.com
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment