Attention is currently required from: Arthur Heymans, Maximilian Brune, ron minnich.
Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81282?usp=email )
Change subject: arch/riscv: reset the pmp on startup
......................................................................
Patch Set 1:
(1 comment)
File src/arch/riscv/virtual_memory.c:
https://review.coreboot.org/c/coreboot/+/81282/comment/61861aeb_be760473 :
PS1, Line 50: reset_pmp();
I'm thinking, if we should move mstatus_init to be invoked much later (e.g. just before the payload is loaded) or split up the function in what is needed early.
Adding more code here before we have any console output can cause frustrating debugging sessions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81282?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id356ea66100582d6750ffa9fc01f031a16835e4f
Gerrit-Change-Number: 81282
Gerrit-PatchSet: 1
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 15 Mar 2024 16:57:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment