Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47715 )
Change subject: mb/clevo/cml-u: Add comment to menu selection ......................................................................
mb/clevo/cml-u: Add comment to menu selection
Change-Id: I531865416b1bf9c5a73c809590059e7d7c8f373a Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/cml-u/Kconfig.name 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/47715/1
diff --git a/src/mainboard/clevo/cml-u/Kconfig.name b/src/mainboard/clevo/cml-u/Kconfig.name index d5f867a..436753f 100644 --- a/src/mainboard/clevo/cml-u/Kconfig.name +++ b/src/mainboard/clevo/cml-u/Kconfig.name @@ -1,2 +1,4 @@ +comment "Comet Lake U" + config BOARD_CLEVO_L140CU bool "L140CU"
Hello Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47715
to look at the new patch set (#2).
Change subject: mb/clevo/cml-u: Add comment to board selection ......................................................................
mb/clevo/cml-u: Add comment to board selection
Change-Id: I531865416b1bf9c5a73c809590059e7d7c8f373a Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/cml-u/Kconfig.name 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/47715/2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47715 )
Change subject: mb/clevo/cml-u: Add comment to board selection ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47715 )
Change subject: mb/clevo/cml-u: Add comment to board selection ......................................................................
Patch Set 2: Code-Review+1
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47715 )
Change subject: mb/clevo/cml-u: Add comment to board selection ......................................................................
mb/clevo/cml-u: Add comment to board selection
Change-Id: I531865416b1bf9c5a73c809590059e7d7c8f373a Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/47715 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/clevo/cml-u/Kconfig.name 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/clevo/cml-u/Kconfig.name b/src/mainboard/clevo/cml-u/Kconfig.name index d5f867a..436753f 100644 --- a/src/mainboard/clevo/cml-u/Kconfig.name +++ b/src/mainboard/clevo/cml-u/Kconfig.name @@ -1,2 +1,4 @@ +comment "Comet Lake U" + config BOARD_CLEVO_L140CU bool "L140CU"
-
Felix Singer (Code Review) -
Michael Niewöhner (Code Review)
-
Paul Menzel (Code Review)