[XS] Change in coreboot[main]: mb/google/geralt: Create variant Ciri

[Paul Menzel (Code Review)]

Attention is currently required from: Hung-Te Lin, Ruihai Zhou.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78954?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: mb/google/geralt: Create variant Ciri
......................................................................

Patch Set 2:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/78954/comment/b38e6053_fbb769e4 :
PS2, Line 9:  and enable MAX98390 AMP for it.
Maybe state, that it’s an exact copy of *Geralt*.

https://review.coreboot.org/c/coreboot/+/78954/comment/b37f1788_f01a1ff3 :
PS2, Line 9: a
the

https://review.coreboot.org/c/coreboot/+/78954/comment/b4a55450_5a522c94 :
PS2, Line 10: 
Please state if future changes are to be expected.

https://review.coreboot.org/c/coreboot/+/78954/comment/92d02953_831676a9 :
PS2, Line 12: TEST=emerge-geralt coreboot
I do not know the Chromium OS tooling, but does this build all the variants?

File src/mainboard/google/geralt/Kconfig:

https://review.coreboot.org/c/coreboot/+/78954/comment/79aad34e_40753c14 :
PS2, Line 73: choice
            : 	prompt "Speaker AMP for Geralt"
            : 	default USE_MAX98390 if BOARD_GOOGLE_GERALT || BOARD_GOOGLE_CIRI
            : 
            : config USE_MAX98390
            : 	bool "MAX98390"
            : 
            : config USE_NAU8318
            : 	bool "NAU8318"
Does this make sense to allow the user to select the speaker AMP?