Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/19480 )
Change subject: soc/intel/apollolake: Use common I2C code from intelblocks ......................................................................
Patch Set 5:
(6 comments)
https://review.coreboot.org/#/c/19480/7/src/soc/intel/apollolake/Makefile.in... File src/soc/intel/apollolake/Makefile.inc:
Line 31: romstage-y += i2c.c
Where did this itss.c come from?
Done
https://review.coreboot.org/#/c/19480/7/src/soc/intel/apollolake/chip.h File src/soc/intel/apollolake/chip.h:
PS7, Line 30: #define APOLLOLAKE_I2C_DEV_MAX 8
Why is this repeated along with a Kconfig value? You're duplicating things.
removed from Kconfig
https://review.coreboot.org/#/c/19480/5/src/soc/intel/apollolake/i2c.c File src/soc/intel/apollolake/i2c.c:
PS5, Line 70: : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : :
I don't understand why all of this support was dropped.
intel/common/blocks/i2c.c implements these, will use those
https://review.coreboot.org/#/c/19480/7/src/soc/intel/apollolake/i2c.c File src/soc/intel/apollolake/i2c.c:
PS7, Line 25: i2c_get_soc_cfg(void)
This isn't even the correct function signature.
Done
PS7, Line 27: DEVTREE_CONST
const
Done
PS7, Line 29: DEVTREE_CONST
const
Done