Attention is currently required from: Anand Vaikar, Felix Held, Fred Reitberger, Martin L Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81036?usp=email )
Change subject: mb/amd/birman_plus: Update glinda DXIO descriptors per schematics
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81036/comment/0c3ee7ca_3d2f4223 :
PS2, Line 7: schematics
What revision?
https://review.coreboot.org/c/coreboot/+/81036/comment/a1b83172_fa2412da :
PS2, Line 9: glinda soc DXIO descriptors are updated for Birman+ mainboard
Please give a quick overview in the commit message.
https://review.coreboot.org/c/coreboot/+/81036/comment/ca363dff_2a69c806 :
PS2, Line 11:
One blank line is enough.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81036?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If22e57fc57b4824550f2dfa8b843a7809c85dbb6
Gerrit-Change-Number: 81036
Gerrit-PatchSet: 2
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 04 Mar 2024 09:35:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment