Change in coreboot[master]: trogdor: Remove Limits config entry.

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Ravi kumar (Code Review)

24 Sep 2020 24 Sep '20

9:09 p.m.

Ravi kumar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45705 )

Change subject: trogdor: Remove Limits config entry. ......................................................................

trogdor: Remove Limits config entry.

Change-Id: Id913fc4a89ad5eff6b3487354ff8be7661539fe5 --- M src/mainboard/google/trogdor/chromeos.fmd 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/45705/1

diff --git a/src/mainboard/google/trogdor/chromeos.fmd b/src/mainboard/google/trogdor/chromeos.fmd index 3aa0473..2783496 100644 --- a/src/mainboard/google/trogdor/chromeos.fmd +++ b/src/mainboard/google/trogdor/chromeos.fmd @@ -11,13 +11,11 @@ } RO_VPD(PRESERVE) 228K RO_DDR_TRAINING(PRESERVE) 8K - RO_LIMITS_CFG(PRESERVE) 4K }

RW_VPD(PRESERVE) 32K RW_NVRAM(PRESERVE) 16K RW_DDR_TRAINING(PRESERVE) 8K - RW_LIMITS_CFG(PRESERVE) 4K RW_ELOG(PRESERVE) 4K RW_SHARED 4K { SHARED_DATA

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Julius Werner (Code Review)

25 Sep 25 Sep

1:03 a.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45705 )

Change subject: trogdor: Remove Limits config entry. ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45705/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45705/1//COMMIT_MSG@9 PS1, Line 9: Change-Id: Id913fc4a89ad5eff6b3487354ff8be7661539fe5 Also needs a Signed-off-by

https://review.coreboot.org/c/coreboot/+/45705/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.fmd:

https://review.coreboot.org/c/coreboot/+/45705/1/src/mainboard/google/trogdo... PS1, Line 12: RO_VPD(PRESERVE) 228K There'll be 4K of empty space in this section now (because there's no section without explicit size in this scope which would expand to fill the free space, like there is for the RW part). So please increase RO_VPD by 4K (to 232K) to make sure we don't waste that.

Or, maybe even better, just remove the `228K` from the RO_VPD line and then it will just fill all available space.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id913fc4a89ad5eff6b3487354ff8be7661539fe5 Gerrit-Change-Number: 45705 Gerrit-PatchSet: 1 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Thu, 24 Sep 2020 23:03:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ravi kumar (Code Review)

28 Sep 28 Sep

8:02 p.m.

Hello build bot (Jenkins), mturney mturney, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45705

to look at the new patch set (#2).

Change subject: trogdor: Remove Limits config entry. ......................................................................

trogdor: Remove Limits config entry.

Change-Id: Id913fc4a89ad5eff6b3487354ff8be7661539fe5 Signed-off-by: Manideep Kurumella mkurumel@codeaurora.org --- M src/mainboard/google/trogdor/chromeos.fmd 1 file changed, 1 insertion(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/45705/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id913fc4a89ad5eff6b3487354ff8be7661539fe5 Gerrit-Change-Number: 45705 Gerrit-PatchSet: 2 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Ravi Kumar Bokka (Code Review)

8:33 p.m.

Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45705 )

Change subject: trogdor: Remove Limits config entry. ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45705/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45705/1//COMMIT_MSG@9 PS1, Line 9: Change-Id: Id913fc4a89ad5eff6b3487354ff8be7661539fe5

...

Also needs a Signed-off-by

Done

https://review.coreboot.org/c/coreboot/+/45705/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.fmd:

https://review.coreboot.org/c/coreboot/+/45705/1/src/mainboard/google/trogdo... PS1, Line 12: RO_VPD(PRESERVE) 228K

...

There'll be 4K of empty space in this section now (because there's no section without explicit size […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id913fc4a89ad5eff6b3487354ff8be7661539fe5 Gerrit-Change-Number: 45705 Gerrit-PatchSet: 2 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Mon, 28 Sep 2020 18:33:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Julius Werner (Code Review)

29 Sep 29 Sep

2:09 a.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45705 )

Change subject: trogdor: Remove Limits config entry. ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id913fc4a89ad5eff6b3487354ff8be7661539fe5 Gerrit-Change-Number: 45705 Gerrit-PatchSet: 2 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Tue, 29 Sep 2020 00:09:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

8 Oct 8 Oct

12:42 a.m.

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45705 )

Change subject: trogdor: Remove Limits config entry. ......................................................................

trogdor: Remove Limits config entry.

Change-Id: Id913fc4a89ad5eff6b3487354ff8be7661539fe5 Signed-off-by: Manideep Kurumella mkurumel@codeaurora.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/45705 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/mainboard/google/trogdor/chromeos.fmd 1 file changed, 1 insertion(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved

diff --git a/src/mainboard/google/trogdor/chromeos.fmd b/src/mainboard/google/trogdor/chromeos.fmd index 3aa0473..1801d34 100644 --- a/src/mainboard/google/trogdor/chromeos.fmd +++ b/src/mainboard/google/trogdor/chromeos.fmd @@ -9,15 +9,13 @@ GBB 0x2f00 RO_FRID 0x100 } - RO_VPD(PRESERVE) 228K + RO_VPD(PRESERVE) RO_DDR_TRAINING(PRESERVE) 8K - RO_LIMITS_CFG(PRESERVE) 4K }

RW_VPD(PRESERVE) 32K RW_NVRAM(PRESERVE) 16K RW_DDR_TRAINING(PRESERVE) 8K - RW_LIMITS_CFG(PRESERVE) 4K RW_ELOG(PRESERVE) 4K RW_SHARED 4K { SHARED_DATA

-- To view, visit https://review.coreboot.org/c/coreboot/+/45705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id913fc4a89ad5eff6b3487354ff8be7661539fe5 Gerrit-Change-Number: 45705 Gerrit-PatchSet: 6 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: merged

1561

days inactive

1574

days old

coreboot-gerrit@coreboot.org

5 comments

3 participants

tags (0)

participants (3)

Julius Werner (Code Review)
Ravi kumar (Code Review)
Ravi Kumar Bokka (Code Review)