Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasperlake ......................................................................
soc/intel/tigerlake: Add FSP header path for Jasperlake
Change-Id: I66d48206a4c1c31802e85c08ab935f81f10aadbc Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/37558/1
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 652c3a3..0f5dbef 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -189,7 +189,8 @@
config FSP_HEADER_PATH string "Location of FSP headers" - default "src/vendorcode/intel/fsp/fsp2_0/tigerlake/" + default "src/vendorcode/intel/fsp/fsp2_0/tigerlake/" if SOC_INTEL_TIGERLAKE + default "src/vendorcode/intel/fsp/fsp2_0/jasperlake/" if SOC_INTEL_JASPERLAKE
config FSP_FD_PATH string
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasperlake ......................................................................
Patch Set 4: Code-Review+1
Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasperlake ......................................................................
Patch Set 5: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasperlake ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37558/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37558/5//COMMIT_MSG@7 PS5, Line 7: Jasperlake Jasper Lake
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasperlake ......................................................................
Patch Set 5: Code-Review+2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasperlake ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37558/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37558/5//COMMIT_MSG@7 PS5, Line 7: Jasperlake
Jasper Lake
SOC name is Jasperlake
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasperlake ......................................................................
Patch Set 6:
Any reason for using this method and not using the 3rdparty/fsp?
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasperlake ......................................................................
Patch Set 6:
Patch Set 6:
Any reason for using this method and not using the 3rdparty/fsp?
the headers are not available in 3rdparty/fsp in early development phase, have to refer it from vendorcode path
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasperlake ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37558/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37558/5//COMMIT_MSG@7 PS5, Line 7: Jasperlake
SOC name is Jasperlake
No. Since Kaby Lake it’s spelled with a space.
Hello Patrick Rudolph, Karthik Ramasubramanian, Mimoja, Subrata Banik, Wonkyu Kim, Maulik V Vaghela, Rizwan Qureshi, V Sowmya, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37558
to look at the new patch set (#7).
Change subject: soc/intel/tigerlake: Add FSP header path for Jasper Lake ......................................................................
soc/intel/tigerlake: Add FSP header path for Jasper Lake
Change-Id: I66d48206a4c1c31802e85c08ab935f81f10aadbc Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/37558/7
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasper Lake ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37558/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37558/5//COMMIT_MSG@7 PS5, Line 7: Jasperlake
No. Since Kaby Lake it’s spelled with a space.
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasper Lake ......................................................................
Patch Set 8: Code-Review+2
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasper Lake ......................................................................
Patch Set 8: Code-Review+2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasper Lake ......................................................................
Patch Set 8: Code-Review+1
Hello Patrick Rudolph, Karthik Ramasubramanian, Mimoja, Subrata Banik, Frans Hendriks, Wonkyu Kim, Maulik V Vaghela, Rizwan Qureshi, V Sowmya, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37558
to look at the new patch set (#10).
Change subject: soc/intel/tigerlake: Add FSP header path for Jasper Lake ......................................................................
soc/intel/tigerlake: Add FSP header path for Jasper Lake
Change-Id: I66d48206a4c1c31802e85c08ab935f81f10aadbc Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/37558/10
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasper Lake ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc... PS10, Line 92: 0x10000 Is this accurate for both TGL and JSL?
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc... PS10, Line 195: FSP_FD_PATH What about this? Shouldn't this be updated as well?
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header path for Jasper Lake ......................................................................
Patch Set 10: -Code-Review
Will remove my +2 until Furquan's comments are addressed
Hello Patrick Rudolph, Karthik Ramasubramanian, Mimoja, Subrata Banik, Frans Hendriks, Wonkyu Kim, Maulik V Vaghela, Rizwan Qureshi, V Sowmya, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37558
to look at the new patch set (#11).
Change subject: soc/intel/tigerlake: Add FSP header and Fsp.fd file path for Jasper Lake ......................................................................
soc/intel/tigerlake: Add FSP header and Fsp.fd file path for Jasper Lake
Change-Id: I66d48206a4c1c31802e85c08ab935f81f10aadbc Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/37558/11
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header and Fsp.fd file path for Jasper Lake ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc... PS10, Line 92: 0x10000
Is this accurate for both TGL and JSL?
No, this needs to be revised. JSL and ICL share same stack and heap requirement, will push a separate CL.
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc... PS10, Line 195: FSP_FD_PATH
What about this? Shouldn't this be updated as well?
Updated.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header and Fsp.fd file path for Jasper Lake ......................................................................
Patch Set 11: Code-Review+2
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header and Fsp.fd file path for Jasper Lake ......................................................................
Patch Set 11: Code-Review+2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header and Fsp.fd file path for Jasper Lake ......................................................................
Patch Set 11: Code-Review+2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header and Fsp.fd file path for Jasper Lake ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc... PS10, Line 92: 0x10000
No, this needs to be revised. […]
Ack
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc... PS10, Line 195: FSP_FD_PATH
Updated.
Done
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header and Fsp.fd file path for Jasper Lake ......................................................................
soc/intel/tigerlake: Add FSP header and Fsp.fd file path for Jasper Lake
Change-Id: I66d48206a4c1c31802e85c08ab935f81f10aadbc Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37558 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Maulik V Vaghela: Looks good to me, approved Frans Hendriks: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 652c3a3..7bb533a 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -189,11 +189,13 @@
config FSP_HEADER_PATH string "Location of FSP headers" - default "src/vendorcode/intel/fsp/fsp2_0/tigerlake/" + default "src/vendorcode/intel/fsp/fsp2_0/tigerlake/" if SOC_INTEL_TIGERLAKE + default "src/vendorcode/intel/fsp/fsp2_0/jasperlake/" if SOC_INTEL_JASPERLAKE
config FSP_FD_PATH string depends on FSP_USE_REPO - default "3rdparty/fsp/TigerLakeFspBinPkg/Fsp.fd" + default "3rdparty/fsp/TigerLakeFspBinPkg/Fsp.fd" if SOC_INTEL_TIGERLAKE + default "3rdparty/fsp/JasperLakeFspBinPkg/Fsp.fd" if SOC_INTEL_JASPERLAKE
endif
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header and Fsp.fd file path for Jasper Lake ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc... PS10, Line 92: 0x10000
Ack
Hi Furquan,
I have updated these Kconfigs here: https://review.coreboot.org/c/coreboot/+/37764
Please review
-
Aamir Bohra (Code Review) -
Frans Hendriks (Code Review)
-
Furquan Shaikh (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Maulik V Vaghela (Code Review)
-
Mimoja (Code Review)
-
Paul Menzel (Code Review)
-
Rizwan Qureshi (Code Review)
-
Subrata Banik (Code Review)
-
Wonkyu Kim (Code Review)