Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33943
Change subject: mainboard/google/hatch: Fix polarity of PCH_WP_OD GPIO ......................................................................
mainboard/google/hatch: Fix polarity of PCH_WP_OD GPIO
This is an active-low signal (need notification when signal goes low). It was continuously being asserted as interrupt 14
14: 11382608 2 0 0 IO-APIC 14-fasteoi INT34BB:00
Change from CROS_GPIO_WP_AH to CROS_GPIO_WP_AL. After this:
14: 0 2 0 0 IO-APIC 14-fasteoi INT34BB:00
BUG=b:136473476 BRANCH=none TEST=Confirmed from kernel that interrupt 14 is not continuously asserted.
Change-Id: Ice6ee081d25d2d0577fd914e7a685d0f3f2f2a74 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/33943/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 9529cc7..296a44a 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -479,7 +479,7 @@
static const struct cros_gpio cros_gpios[] = { CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), - CROS_GPIO_WP_AH(GPIO_PCH_WP, CROS_GPIO_DEVICE_NAME), + CROS_GPIO_WP_AL(GPIO_PCH_WP, CROS_GPIO_DEVICE_NAME), };
const struct cros_gpio *__weak variant_cros_gpios(size_t *num)
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33943 )
Change subject: mainboard/google/hatch: Fix polarity of PCH_WP_OD GPIO ......................................................................
Patch Set 1: Code-Review+1
Tim Wawrzynczak has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33943 )
Change subject: mainboard/google/hatch: Fix polarity of PCH_WP_OD GPIO ......................................................................
Abandoned
Already fixed
-
Paul Menzel (Code Review) -
Tim Wawrzynczak (Code Review)