Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Shuo Liu, Tim Chu.
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80793?usp=email )
Change subject: soc/intel/xeon_sp/spr: Fix IOAT resources ......................................................................
soc/intel/xeon_sp/spr: Fix IOAT resources
Do not generate empty mem32 resources for CPMx or HQMx stacks. Switch existing arguments to make sure that base is bigger than limit to indicate that the resource is invalid.
Change-Id: I679563e97c33c7ee35d402674972e55f521eafa8 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/soc/intel/xeon_sp/spr/ioat.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/80793/1
diff --git a/src/soc/intel/xeon_sp/spr/ioat.c b/src/soc/intel/xeon_sp/spr/ioat.c index 60aae24..ed01e15 100644 --- a/src/soc/intel/xeon_sp/spr/ioat.c +++ b/src/soc/intel/xeon_sp/spr/ioat.c @@ -96,7 +96,7 @@ mem64_limit = mem64_base + CPM_MMIO_SIZE - 1; bus_base = sr->BusBase + CPM_BUS_OFFSET; bus_limit = bus_base + CPM_RESERVED_BUS; - create_ioat_domain(path, bus, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit, + create_ioat_domain(path, bus, bus_base, bus_limit, -1, 0, mem64_base, mem64_limit, DOMAIN_TYPE_CPM0);
/* HQM0 */ @@ -104,7 +104,7 @@ mem64_limit = mem64_base + HQM_MMIO_SIZE - 1; bus_base = sr->BusBase + HQM_BUS_OFFSET; bus_limit = bus_base + HQM_RESERVED_BUS; - create_ioat_domain(path, bus, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit, + create_ioat_domain(path, bus, bus_base, bus_limit, -1, 0, mem64_base, mem64_limit, DOMAIN_TYPE_HQM0);
/* CPM1 (optional) */ @@ -113,7 +113,7 @@ bus_base = sr->BusBase + CPM1_BUS_OFFSET; bus_limit = bus_base + CPM_RESERVED_BUS; if (bus_limit <= sr->BusLimit) - create_ioat_domain(path, bus, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit, + create_ioat_domain(path, bus, bus_base, bus_limit, -1, 0, mem64_base, mem64_limit, DOMAIN_TYPE_CPM1);
/* HQM1 (optional) */ @@ -122,7 +122,7 @@ bus_base = sr->BusBase + HQM1_BUS_OFFSET; bus_limit = bus_base + HQM_RESERVED_BUS; if (bus_limit <= sr->BusLimit) - create_ioat_domain(path, bus, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit, + create_ioat_domain(path, bus, bus_base, bus_limit, -1, 0, mem64_base, mem64_limit, DOMAIN_TYPE_HQM1);
/* DINO */