Attention is currently required from: Lance Zhao, Nico Huber, Tim Wawrzynczak.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60645 )
Change subject: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Old and new syntax was mixed before these patches. That is nothing new. Not speaking of the different spellings of the instructions, like LAnd, Land or land. Yes, ASL is case-insensitive and it's the same syntax, but it's a mess. So not many people care about that.
Please note in the commit messages if the resulting byte code changes.
Not doable for such an amount of patches.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2a0b13522761e7113d1dc5b78d0dfd19a6cfd94
Gerrit-Change-Number: 60645
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sun, 02 Jan 2022 13:17:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment