HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34263 )
Change subject: soc/intel/apollolake: Add missing typedef gpio_t ......................................................................
soc/intel/apollolake: Add missing typedef gpio_t
<soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Change-Id: I1ede5e9ebb6bdcd9f49b8d67ab53d0fddb1a3d24 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/apollolake/include/soc/gpio.h 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/34263/1
diff --git a/src/soc/intel/apollolake/include/soc/gpio.h b/src/soc/intel/apollolake/include/soc/gpio.h index 939c449..ca3b96b 100644 --- a/src/soc/intel/apollolake/include/soc/gpio.h +++ b/src/soc/intel/apollolake/include/soc/gpio.h @@ -24,4 +24,8 @@ #endif #include <intelblocks/gpio.h>/* intelblocks/gpio.h depends on definitions in soc/gpio_glk.h and soc/gpio_apl.h */ + +/* <soc/gpio.h> must typedef a gpio_t that fits in 32 bits. */ +typedef uint32_t gpio_t; + #endif
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34263
to look at the new patch set (#2).
Change subject: soc/intel/apollolake: Add missing typedef gpio_t ......................................................................
soc/intel/apollolake: Add missing typedef gpio_t
<soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Change-Id: I1ede5e9ebb6bdcd9f49b8d67ab53d0fddb1a3d24 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/apollolake/include/soc/gpio.h 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/34263/2
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34263
to look at the new patch set (#3).
Change subject: soc/intel/apollolake: Add missing typedef gpio_t ......................................................................
soc/intel/apollolake: Add missing typedef gpio_t
<soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Change-Id: I1ede5e9ebb6bdcd9f49b8d67ab53d0fddb1a3d24 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/apollolake/include/soc/gpio.h 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/34263/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34263 )
Change subject: soc/intel/apollolake: Add missing typedef gpio_t ......................................................................
Patch Set 3:
(1 comment)
I don't think any of it would compile if the type was really missing...
https://review.coreboot.org/c/coreboot/+/34263/3/src/soc/intel/apollolake/in... File src/soc/intel/apollolake/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/34263/3/src/soc/intel/apollolake/in... PS3, Line 31: #include <intelblocks/gpio.h>/* intelblocks/gpio.h depends on definitions in defined in here?
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34263 )
Change subject: soc/intel/apollolake: Add missing typedef gpio_t ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)