Attention is currently required from: Martin Roth - Personal, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 )
Change subject: [WIP]drivers/efi: Add UEFI variable store option support ......................................................................
Patch Set 2:
(16 comments)
File src/commonlib/bsd/include/commonlib/bsd/cb_err.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/28ea546d_9d034570 PS2, Line 29: CB_EFI_VS_NOT_FORMATED_INVALID = -107, /**< UEFI variable store not formated */ 'FORMATED' may be misspelled - perhaps 'FORMATTED'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/e79e5d68_961c954f PS2, Line 29: CB_EFI_VS_NOT_FORMATED_INVALID = -107, /**< UEFI variable store not formated */ 'formated' may be misspelled - perhaps 'formatted'?
File src/drivers/efi/efi.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/69cf32c5_1f66bc71 PS2, Line 9: enum cb_err efi_fv_get_option(struct region_device *rdev, const char *name, void *dest, uint32_t *size); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/8b888006_accd8b22 PS2, Line 10: enum cb_err efi_fv_set_option(struct region_device *rdev, const char *name, void *data, size_t size); line over 96 characters
File src/drivers/efi/efi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/44557051_5314c67f PS2, Line 82: if ( (fw_vol_hdr->Revision != EFI_FVH_REVISION) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/5df5a906_5a4002bb PS2, Line 82: if ( (fw_vol_hdr->Revision != EFI_FVH_REVISION) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/6184cfa4_c6a63ab5 PS2, Line 147: return CB_EFI_VS_NOT_FORMATED_INVALID; 'FORMATED' may be misspelled - perhaps 'FORMATTED'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/34a2da07_696376c6 PS2, Line 235: !name ) { space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/4906ccc3_53cb6dca PS2, Line 250: if (rdev_readat(rdev, data, header_size + name_size, data_size) != data_size) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/6a30a138_53ee5a7f PS2, Line 250: if (rdev_readat(rdev, data, header_size + name_size, data_size) != data_size) Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/1aacdb5d_2704ee04 PS2, Line 275: enum cb_err efi_fv_get_option(struct region_device *rdev, const char *name, void *dest, uint32_t *size) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/f4dac5ff_51fb1ccc PS2, Line 307: enum cb_err efi_fv_set_option(struct region_device *rdev, const char *name, void *data, size_t size) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/0980d364_57d200d7 PS2, Line 345: auth_hdr.Attributes = EFI_VARIABLE_NON_VOLATILE|EFI_VARIABLE_BOOTSERVICE_ACCESS|EFI_VARIABLE_RUNTIME_ACCESS; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/4989440b_ce366ba7 PS2, Line 357: if (rdev_writeat(rdev, &auth_hdr.State, offsetof(AUTHENTICATED_VARIABLE_HEADER, State), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/c0ee0360_66018b01 PS2, Line 369: hdr.Attributes = EFI_VARIABLE_NON_VOLATILE|EFI_VARIABLE_BOOTSERVICE_ACCESS|EFI_VARIABLE_RUNTIME_ACCESS; line over 96 characters
File src/drivers/efi/option.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140596): https://review.coreboot.org/c/coreboot/+/52564/comment/66948c7d_40a4a663 PS2, Line 43: } adding a line without newline at end of file
-
build bot (Jenkins) (Code Review)