Change in ...coreboot[master]: rmodule: Add support for R_X86_64_PLT32 - coreboot-gerrit

28 Feb 2019


      Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31468 )
Change subject: rmodule: Add support for R_X86_64_PLT32
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31468/2//COMMIT_MSG 
Commit Message:
https://review.coreboot.org/#/c/31468/2//COMMIT_MSG@13 
PS2, Line 13: R_X86_64_PLT32
...
I'm not sure we should be allowing the compiler/linker to emit these relocations. […]
I tried to disable it, but it's not possible.
It's tested on qemu and works fine.
It's also done here:
https://lists.gnu.org/archive/html/grub-devel/2018-02/msg00064.html
or here
https://lore.kernel.org/patchwork/patch/895855/
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31468
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81350d2728c20ac72cc865e7ba92319858352632
Gerrit-Change-Number: 31468
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Sol Boucher solb@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Feb 2019 18:18:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Gerrit-MessageType: comment