Attention is currently required from: Nico Huber, Benjamin Doron, Paul Menzel, Angel Pons, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51796 )
Change subject: [WIP] soc/intel/common: Add InSMM.STS support
......................................................................
Patch Set 6:
(2 comments)
File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/51796/comment/98eb2b72_7cd398b4
PS6, Line 276: 0x1fe
Yeah, the thing is... […]
do we know which are supported and which not?
https://review.coreboot.org/c/coreboot/+/51796/comment/bd15e550_dd9af896
PS6, Line 267: msr_t msr = {
: .lo = read32((void *)(uintptr_t)0xfed30880),
: .hi = 0,
: };
: if (enable_writes)
: msr.lo |= 1;
: else
: msr.lo &= ~1;
:
: wrmsr(0x1fe, msr);
:
This would read MSR 0x1fe, and I don't know what happens in that case. […]
ok, two questions:
1) what is that msr? haven't found it on a quick search
2) do we have to write the value from that mem address when enable_writes == 0?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia90c0e3f8ccf895bfb6d46ffe26750393dab95fb
Gerrit-Change-Number: 51796
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 20 Apr 2021 13:53:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment