Change in ...coreboot[master]: drivers/intel/fsp1_1/raminit.c: Make check FSP HOBs independent of CO...

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29371 )

Change subject: drivers/intel/fsp1_1/raminit.c: Make check FSP HOBs independent of CONFIG_DISPLAY_HOBS
......................................................................

Patch Set 4:
> Patch Set 3:
> > Patch Set 3:
> >
> > (3 comments)
> >
> > Please clean up and separate HOB checking and HOB displaying. You have also enabled prints that are a part of displaying the hobs after removing the macro.
>
> I don't agree 100% with your comment. The Hobs are handled the same way as FSP_BOOTLOADER_TOLUM_HOB and FSP_SMBIOS_MEMORY_INFO_HOB now.
>
> We might consider if CONFIG_DISPLAY_HOBS should disable and hob information, but don't disable verification of the required hobs.

We may have a misunderstanding here. What I meant is to move all prints in cases where we only print HOB's pointer. I agree that FSP_BOOTLOADER_TOLUM_HOB is somewhat different because it is related to cbmem root. The prints for this HOB should remain where they are. However I do not see the point of printing simple HOB pointer without HOB display option enabled. I am especially talking about FSP_NON_VOLATILE_STORAGE_HOB, FSP_SMBIOS_MEMORY_INFO where we simply print the HOB pointer if the check passes. IMO not necessary and we should even remove those prints, beause print_hob_type_structure prints the pointers either way.