Change in coreboot[master]: soc/amd/picasso: use SMBus timeout in compliation unit

[Aaron Durbin (Code Review)]

Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38614 )

Change subject: soc/amd/picasso: use SMBus timeout in compliation unit
......................................................................

soc/amd/picasso: use SMBus timeout in compliation unit

The timeout is fixed and only used in one place. Put the assumption
in the compliation unit utilizing the defintion.

Change-Id: I93c061e74df6b4265fd1c61fc4669410ebc9554f
Signed-off-by: Aaron Durbin 
---
M src/soc/amd/picasso/include/soc/smbus.h
M src/soc/amd/picasso/smbus.c
2 files changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38614/1

diff --git a/src/soc/amd/picasso/include/soc/smbus.h b/src/soc/amd/picasso/include/soc/smbus.h
index 60b8bfa..524be77 100644
--- a/src/soc/amd/picasso/include/soc/smbus.h
+++ b/src/soc/amd/picasso/include/soc/smbus.h
@@ -19,12 +19,6 @@
 #include <stdint.h>
 #include <soc/iomap.h>

-/*
- * Between 1-10 seconds, We should never timeout normally
- * Longer than this is just painful when a timeout condition occurs.
- */
-#define SMBUS_TIMEOUT (100 * 1000 * 10)
-
 int do_smbus_read_byte(u32 mmio, u8 device, u8 address);
 int do_smbus_write_byte(u32 mmio, u8 device, u8 address, u8 val);
 int do_smbus_recv_byte(u32 mmio, u8 device);
diff --git a/src/soc/amd/picasso/smbus.c b/src/soc/amd/picasso/smbus.c
index 79f09d6..f5a9d60 100644
--- a/src/soc/amd/picasso/smbus.c
+++ b/src/soc/amd/picasso/smbus.c
@@ -19,6 +19,12 @@
 #include <soc/smbus.h>
 #include <soc/southbridge.h>

+/*
+ * Between 1-10 seconds, We should never timeout normally
+ * Longer than this is just painful when a timeout condition occurs.
+ */
+#define SMBUS_TIMEOUT (100 * 1000 * 10)
+
 static u8 controller_read8(u32 base, u8 reg)
 {
    switch (base) {

[Aaron Durbin (Code Review)]

Aaron Durbin has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/38614 )

Change subject: soc/amd/picasso: use SMBus timeout in compliation unit
......................................................................

soc/amd/picasso: use SMBus timeout in compliation unit

The timeout is fixed and only used in one place. Put the assumption
in the compliation unit utilizing the defintion.

Change-Id: I93c061e74df6b4265fd1c61fc4669410ebc9554f
Signed-off-by: Aaron Durbin 
---
M src/soc/amd/picasso/include/soc/smbus.h
M src/soc/amd/picasso/smbus.c
2 files changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38614/2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38614 )

Change subject: soc/amd/picasso: use SMBus timeout in compliation unit
......................................................................

Patch Set 2: Code-Review+1

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38614 )

Change subject: soc/amd/picasso: use SMBus timeout in compliation unit
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38614/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38614/2//COMMIT_MSG@7 
PS2, Line 7: compliation
compilation

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38614 )

Change subject: soc/amd/picasso: use SMBus timeout in compliation unit
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38614/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38614/2//COMMIT_MSG@7 
PS2, Line 7: compliation
> compilation

Done

Change in coreboot[master]: soc/amd/picasso: use SMBus timeout in compilation unit

[Aaron Durbin (Code Review)]

Hello Kyösti Mälkki, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38614

to look at the new patch set (#3).

Change subject: soc/amd/picasso: use SMBus timeout in compilation unit
......................................................................

soc/amd/picasso: use SMBus timeout in compilation unit

The timeout is fixed and only used in one place. Put the assumption
in the compliation unit utilizing the defintion.

Change-Id: I93c061e74df6b4265fd1c61fc4669410ebc9554f
Signed-off-by: Aaron Durbin 
---
M src/soc/amd/picasso/include/soc/smbus.h
M src/soc/amd/picasso/smbus.c
2 files changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38614/3

Change in coreboot[master]: soc/amd/picasso: use SMBus timeout in compilation unit

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38614 )

Change subject: soc/amd/picasso: use SMBus timeout in compilation unit
......................................................................

Patch Set 3: Code-Review+1

Change in coreboot[master]: soc/amd/picasso: use SMBus timeout in compilation unit

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38614 )

Change subject: soc/amd/picasso: use SMBus timeout in compilation unit
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: soc/amd/picasso: use SMBus timeout in compilation unit

[Aaron Durbin (Code Review)]

Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38614 )

Change subject: soc/amd/picasso: use SMBus timeout in compilation unit
......................................................................

soc/amd/picasso: use SMBus timeout in compilation unit

The timeout is fixed and only used in one place. Put the assumption
in the compliation unit utilizing the defintion.

Change-Id: I93c061e74df6b4265fd1c61fc4669410ebc9554f
Signed-off-by: Aaron Durbin 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38614
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
Reviewed-by: Angel Pons 
---
M src/soc/amd/picasso/include/soc/smbus.h
M src/soc/amd/picasso/smbus.c
2 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/amd/picasso/include/soc/smbus.h b/src/soc/amd/picasso/include/soc/smbus.h
index 60b8bfa..524be77 100644
--- a/src/soc/amd/picasso/include/soc/smbus.h
+++ b/src/soc/amd/picasso/include/soc/smbus.h
@@ -19,12 +19,6 @@
 #include <stdint.h>
 #include <soc/iomap.h>

-/*
- * Between 1-10 seconds, We should never timeout normally
- * Longer than this is just painful when a timeout condition occurs.
- */
-#define SMBUS_TIMEOUT (100 * 1000 * 10)
-
 int do_smbus_read_byte(u32 mmio, u8 device, u8 address);
 int do_smbus_write_byte(u32 mmio, u8 device, u8 address, u8 val);
 int do_smbus_recv_byte(u32 mmio, u8 device);
diff --git a/src/soc/amd/picasso/smbus.c b/src/soc/amd/picasso/smbus.c
index 79f09d6..f5a9d60 100644
--- a/src/soc/amd/picasso/smbus.c
+++ b/src/soc/amd/picasso/smbus.c
@@ -19,6 +19,12 @@
 #include <soc/smbus.h>
 #include <soc/southbridge.h>

+/*
+ * Between 1-10 seconds, We should never timeout normally
+ * Longer than this is just painful when a timeout condition occurs.
+ */
+#define SMBUS_TIMEOUT (100 * 1000 * 10)
+
 static u8 controller_read8(u32 base, u8 reg)
 {
    switch (base) {