Change in coreboot[master]: mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touc...
Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35000 )
Change subject: mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touchscreen ......................................................................
mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touchscreen
BUG=b:139699619 TEST=emerge-grunt coreboot chromeos-bootimage flash bios image to DUT and make sure the touchpad and touchscreen can work
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I002badd49e678e1c32c802352923ca51efb45cef --- M src/mainboard/google/kahlee/variants/treeya/devicetree.cb 1 file changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35000/1
diff --git a/src/mainboard/google/kahlee/variants/treeya/devicetree.cb b/src/mainboard/google/kahlee/variants/treeya/devicetree.cb index d73c47c..81f4002 100644 --- a/src/mainboard/google/kahlee/variants/treeya/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/treeya/devicetree.cb @@ -138,10 +138,33 @@ register "desc" = ""ELAN Touchpad"" register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)" register "wake" = "7" + register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)" + register "generic.wake" = "7" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end end device mmio 0xfedc5000 on + chip drivers/i2c/hid + register "generic.hid" = ""SYTS7817"" + register "generic.desc" = ""Synaptics Touchscreen"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_11)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_85)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)" + register "generic.reset_delay_ms" = "45" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 20 on end + end chip drivers/i2c/generic register "hid" = ""RAYD0001"" register "desc" = ""Raydium Touchscreen""
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35000 )
Change subject: mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touchscreen ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/treeya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee... PS1, Line 147: ACPI_GPIO_IRQ_LEVEL_LOW( Could you help check the spec for which mode this irq triggered? edge or level?
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee... PS1, Line 158: ACPI_GPIO_IRQ_LEVEL_LOW the same as above.
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35000
to look at the new patch set (#2).
Change subject: mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touchscreen ......................................................................
mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touchscreen
BUG=b:139699619 TEST=emerge-grunt coreboot chromeos-bootimage flash bios image to DUT and make sure the touchpad and touchscreen can work
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I002badd49e678e1c32c802352923ca51efb45cef --- M src/mainboard/google/kahlee/variants/treeya/devicetree.cb 1 file changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35000/2
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35000 )
Change subject: mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touchscreen ......................................................................
Patch Set 2:
(2 comments)
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/treeya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee... PS1, Line 147: ACPI_GPIO_IRQ_LEVEL_LOW(
Could you help check the spec for which mode this irq triggered? edge or level?
Hi Chris,
I have confirmed with our EE, trigger method is edge. This device leverage to our Phaser project. Thanks a lot!
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee... PS1, Line 158: ACPI_GPIO_IRQ_LEVEL_LOW
the same as above.
It is same with above.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35000 )
Change subject: mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touchscreen ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/treeya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee... PS1, Line 147: ACPI_GPIO_IRQ_LEVEL_LOW(
Hi Chris, […]
Done
https://review.coreboot.org/c/coreboot/+/35000/1/src/mainboard/google/kahlee... PS1, Line 158: ACPI_GPIO_IRQ_LEVEL_LOW
It is same with above.
Done
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35000 )
Change subject: mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touchscreen ......................................................................
Patch Set 2: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35000 )
Change subject: mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touchscreen ......................................................................
mb/google/kahlee/treeya: Enable Synaptics touchpad and Synaptics touchscreen
BUG=b:139699619 TEST=emerge-grunt coreboot chromeos-bootimage flash bios image to DUT and make sure the touchpad and touchscreen can work
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I002badd49e678e1c32c802352923ca51efb45cef Reviewed-on: https://review.coreboot.org/c/coreboot/+/35000 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/google/kahlee/variants/treeya/devicetree.cb 1 file changed, 23 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/treeya/devicetree.cb b/src/mainboard/google/kahlee/variants/treeya/devicetree.cb index d73c47c..eb76e94 100644 --- a/src/mainboard/google/kahlee/variants/treeya/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/treeya/devicetree.cb @@ -138,10 +138,33 @@ register "desc" = ""ELAN Touchpad"" register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)" register "wake" = "7" + register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_5)" + register "generic.wake" = "7" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end end device mmio 0xfedc5000 on + chip drivers/i2c/hid + register "generic.hid" = ""SYTS7817"" + register "generic.desc" = ""Synaptics Touchscreen"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_11)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_85)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)" + register "generic.reset_delay_ms" = "45" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 20 on end + end chip drivers/i2c/generic register "hid" = ""RAYD0001"" register "desc" = ""Raydium Touchscreen""
-
chris wang (Code Review) -
Martin Roth (Code Review)
-
Peichao Li (Code Review)