Change in coreboot[master]: soc/intel/common/block/tcss: Add common code support for TCSS
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41010 )
Change subject: soc/intel/common/block/tcss: Add common code support for TCSS ......................................................................
soc/intel/common/block/tcss: Add common code support for TCSS
For now only added CONFIG_TCSS_PCIE_SEGMENT Kconfig to allow dedicated PCI segment support for iTBT.
SoC user can select CONFIG_TCSS_PCIE_SEGMENT from dedicated SoC Kconfig to include this support.
Change-Id: I33c1e5612a6d4882377784294ca0bcef131f2c0a Signed-off-by: Subrata Banik subrata.banik@intel.com --- A src/soc/intel/common/block/tcss/Kconfig 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/41010/1
diff --git a/src/soc/intel/common/block/tcss/Kconfig b/src/soc/intel/common/block/tcss/Kconfig new file mode 100644 index 0000000..0f7fe7c --- /dev/null +++ b/src/soc/intel/common/block/tcss/Kconfig @@ -0,0 +1,9 @@ +config SOC_INTEL_COMMON_BLOCK_TCSS + bool + help + Intel Processor common TCSS support + +config TCSS_PCIE_SEGMENT + bool + help + Indicate the extra PCIE segment is required for iTBT or not
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41010 )
Change subject: soc/intel/common/block/tcss: Add common code support for TCSS ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Nico Huber, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41010
to look at the new patch set (#2).
Change subject: soc/intel/common/block/tcss: Add common code support for TCSS ......................................................................
soc/intel/common/block/tcss: Add common code support for TCSS
For now only added CONFIG_TCSS_PCIE_SEGMENT Kconfig to allow dedicated PCI segment support for iTBT.
SoC user can select CONFIG_TCSS_PCIE_SEGMENT from dedicated SoC Kconfig to include this support.
Additionally override CONFIG_PCI_SEGMENT_GROUPS if TCSS_PCIE_SEGMENT is selected.
Change-Id: I33c1e5612a6d4882377784294ca0bcef131f2c0a Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/block/systemagent/Kconfig A src/soc/intel/common/block/tcss/Kconfig 2 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/41010/2
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41010 )
Change subject: soc/intel/common/block/tcss: Add common code support for TCSS ......................................................................
Patch Set 3: Code-Review+1
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41010 )
Change subject: soc/intel/common/block/tcss: Add common code support for TCSS ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41010/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41010/3//COMMIT_MSG@10 PS3, Line 10: iTBT Is this thunderbolt specific or applicable to USB4 as well?
https://review.coreboot.org/c/coreboot/+/41010/3/src/soc/intel/common/block/... File src/soc/intel/common/block/tcss/Kconfig:
https://review.coreboot.org/c/coreboot/+/41010/3/src/soc/intel/common/block/... PS3, Line 4: Intel Processor common TCSS support This option seems to be unused. Should TCSS_PCIE_SEGMENT be dependent on this Kconfig?
https://review.coreboot.org/c/coreboot/+/41010/3/src/soc/intel/common/block/... PS3, Line 6: TCSS_PCIE_SEGMENT why 'E' in PCIE? It's not necessarily pci express.
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41010?usp=email )
Change subject: soc/intel/common/block/tcss: Add common code support for TCSS ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Aaron Durbin (Code Review) -
Martin L Roth (Code Review)
-
Nico Huber (Code Review)
-
Subrata Banik (Code Review)
-
Wonkyu Kim (Code Review)