Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33507
Change subject: mb/packardbell/ms2290/Kconfig: Remove ARCH_x options ......................................................................
mb/packardbell/ms2290/Kconfig: Remove ARCH_x options
Those are already selected in cpu/intel/model_2065x/Kconfig.
Change-Id: I7421faa24b8a95d2780bce0651cde0bfeb357833 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/packardbell/ms2290/Kconfig 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/33507/1
diff --git a/src/mainboard/packardbell/ms2290/Kconfig b/src/mainboard/packardbell/ms2290/Kconfig index c6a1e12..6315591 100644 --- a/src/mainboard/packardbell/ms2290/Kconfig +++ b/src/mainboard/packardbell/ms2290/Kconfig @@ -3,9 +3,6 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select SYSTEM_TYPE_LAPTOP - select ARCH_BOOTBLOCK_X86_32 - select ARCH_ROMSTAGE_X86_32 - select ARCH_RAMSTAGE_X86_32 select NORTHBRIDGE_INTEL_NEHALEM select SOUTHBRIDGE_INTEL_IBEXPEAK select HAVE_OPTION_TABLE
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33507 )
Change subject: mb/packardbell/ms2290/Kconfig: Remove ARCH_x options ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33507 )
Change subject: mb/packardbell/ms2290/Kconfig: Remove ARCH_x options ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33507 )
Change subject: mb/packardbell/ms2290/Kconfig: Remove ARCH_x options ......................................................................
mb/packardbell/ms2290/Kconfig: Remove ARCH_x options
Those are already selected in cpu/intel/model_2065x/Kconfig.
Change-Id: I7421faa24b8a95d2780bce0651cde0bfeb357833 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/33507 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/packardbell/ms2290/Kconfig 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/packardbell/ms2290/Kconfig b/src/mainboard/packardbell/ms2290/Kconfig index c6a1e12..6315591 100644 --- a/src/mainboard/packardbell/ms2290/Kconfig +++ b/src/mainboard/packardbell/ms2290/Kconfig @@ -3,9 +3,6 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select SYSTEM_TYPE_LAPTOP - select ARCH_BOOTBLOCK_X86_32 - select ARCH_ROMSTAGE_X86_32 - select ARCH_RAMSTAGE_X86_32 select NORTHBRIDGE_INTEL_NEHALEM select SOUTHBRIDGE_INTEL_IBEXPEAK select HAVE_OPTION_TABLE
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33507 )
Change subject: mb/packardbell/ms2290/Kconfig: Remove ARCH_x options ......................................................................
Patch Set 3: Code-Review+1
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)