Change in coreboot[master]: soc/intel/common/block/uart: rework to use dummy device

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48385 )

Change subject: soc/intel/common/block/uart: rework to use dummy device
......................................................................

Patch Set 3:
> Patch Set 3: Code-Review-2
>
> I can't say if this is working, or even if it can work.

I wonder how this one is different from drivers/wifi/generic, which uses the same dummy model?
> about all the mainboards that use this driver by properly
> matching the PCI IDs?
>
> TBH, I don't like to see any more hacks with fake chips or
> devices. The old model of attaching drivers via PCI IDs
> served us well for a long time. Now Intel makes more and
> more PCI devices that actually aren't PCI devices. I think
> it's time we adapt and find a new model to attach drivers.
>
> As we have chipset devicetrees now, it makes things easy
> to match device drivers by name. Just like we do it for
> chip drivers. So my idea would be to do something like
> this:
>
> device pci 19.2 hidden
>            driver soc/intel/common/block/uart
>    end
>
> And then name the `struct pci_driver`
> `soc_intel_common_block_uart_driver` accordingly.
>
> Just from the top of my head. Alternative suggestions
> are most welcome :)

If we're going to do that, we should do this tree-wide,
else we have again multiple different models.
> Another idea to solve one of the issues this chip driver
> currently handles: Allow to specify the PCI IDs in the
> devicetree if the device is `hidden`.

Huh, that is already possible (devid)