build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29023 )
Change subject: riscv: add support smp_pause / smp_resume
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/#/c/29023/9/src/arch/riscv/smp.c
File src/arch/riscv/smp.c:
https://review.coreboot.org/#/c/29023/9/src/arch/riscv/smp.c@41
PS9, Line 41: die("smp_resume must pass a non-null function pointer\n");
Prefer using '"%s...", __func__' to using 'smp_resume', this function's name, in a string
--
To view, visit
https://review.coreboot.org/29023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8159637bfb15f54f0abeb335de2ba6e9cf82fb
Gerrit-Change-Number: 29023
Gerrit-PatchSet: 9
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn Chang
citypw@gmail.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 15 Oct 2018 14:27:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No