Attention is currently required from: Hung-Te Lin, Jason Glenesk, Raul Rangel, Matt DeVillier, Julius Werner, Fred Reitberger, Felix Held.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66909 )
Change subject: vboot: Add VBOOT_CBFS_INTEGRATION support
......................................................................
Patch Set 20:
(4 comments)
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66909/comment/1f7ae90a_ef5c01bc
PS15, Line 104: bootblock-y += secdata_mock.c
The parentheses aren't right, that's why you get that error. […]
Oh..... My confusion was caused by incorrect parentheses placement. Now it makes sense. Sorry for that and thank you for help :)
File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66909/comment/fb5e7000_6d52f6af
PS18, Line 40: postcar-y += i2c.c
I think you should no longer need this
Done
File src/soc/qualcomm/ipq40xx/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66909/comment/9b2adb84_ef26b52f
PS18, Line 7: bootblock-y += i2c.c
and this
Done
File src/soc/qualcomm/ipq806x/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66909/comment/1cd79ba6_1bb46066
PS18, Line 7: bootblock-y += i2c.c
and this
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66909
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40ae01c477c4e4f7a1c90e4026a8a868ae64b5ca
Gerrit-Change-Number: 66909
Gerrit-PatchSet: 20
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 02 Nov 2022 10:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment