[S] Change in coreboot[main]: soc/intel/adl: Display low battery message on screen

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro.

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86224?usp=email )

Change subject: soc/intel/adl: Display low battery message on screen
......................................................................

Patch Set 2:

(9 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86224/comment/ee3f7725_353df5fa?usp... :
PS1, Line 7: soc/intel/adl: Display low battery message on screen
> Looks like you have room to spell alderlake.

Acknowledged

https://review.coreboot.org/c/coreboot/+/86224/comment/5134868a_7545f04c?usp... :
PS1, Line 9: This commit adds a function ux_inform_user_of_poweroff_operation
> > This is 75. Cf. https://doc.coreboot.org/contributing/gerrit_guidelines. […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/86224/comment/155f69ca_4ce587a1?usp... :
PS1, Line 11:
> Nit: Seems there is an extra space.

Acknowledged

https://review.coreboot.org/c/coreboot/+/86224/comment/47ded586_08675613?usp... :
PS1, Line 16: use
> Nit: used

Acknowledged

https://review.coreboot.org/c/coreboot/+/86224/comment/11b8e740_76ef144f?usp... :
PS1, Line 16: rely
> Nit: relies

Acknowledged

File src/soc/intel/alderlake/romstage/ux.c:

https://review.coreboot.org/c/coreboot/+/86224/comment/0465f578_84c159f3?usp... :
PS1, Line 42: 	if (!CONFIG(CHROMEOS_ENABLE_ESOL) ||
> should fit on one line.

Acknowledged

https://review.coreboot.org/c/coreboot/+/86224/comment/e930521f_1e572826?usp... :
PS1, Line 50: UX_MEMORY_TRAINING_DESC
> Should it be a different locale name here instead of relying on memory training?

Acknowledged

https://review.coreboot.org/c/coreboot/+/86224/comment/66d9910f_d7c44a72?usp... :
PS1, Line 53: 		text = "Battery critically low. Shutting down";
> nit: a dot at the end?

Acknowledged

https://review.coreboot.org/c/coreboot/+/86224/comment/683c4478_aa70bdd1?usp... :
PS1, Line 59: }
> Looks like both `ux_inform_user_of_update_operation` and `user_inform_user_of_poweroff_operation` ha […]

Acknowledged